Project

General

Profile

Actions
Copy link

Bug #28860

closed

Wrong Error Message/Return code getting after exceeding the 'failed_login_attempts_limit'

Added by Tomer Brisker about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominik Matoulek
Category:
Authentication
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
1778599
Pull request:
https://github.com/theforeman/foreman/pull/7405, https://github.com/theforeman/foreman/pull/7423, https://github.com/theforeman/foreman/pull/7424
Fixed in Releases:
1.23.2, 1.24.3, 2.0.0
Found in Releases:
Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1778599

Description of problem:
Wrong Error Message/Return code(Internal server error) getting after exceeding the 'failed_login_attempts_limit'

Version-Release number of selected component (if applicable):

How reproducible:
Always

Steps to Reproduce:
[root@satellite]# hammer -u admin -p changeme settings set --name failed_login_attempts_limit --value 5

Setting [failed_login_attempts_limit] updated to [5].
[root@satellite ~]# for i in 1 2 3 4 5; do hammer -u admin -p WRONG_PASS user list; done
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin

[root@satellite ~]# hammer -u admin -p changeme user list
undefined local variable or method `logger' for #<Foreman::BruteforceProtection:0x00007f80b6979698>

Actual results:
Error Message is shown as 'undefined local variable or method `logger' for #<Foreman::BruteforceProtection:0x00007f80b6979698>' and error code is '70'

Expected results:
Error Message is Incorrect and Return code should be '129'

Related issues 1 (0 open — 1 closed)

Related to Foreman - Feature #26887: graphql login: count login failures as brute force attemptsClosedTimo GoebelActions
Actions
Copy link
 #1

Updated by Tomer Brisker about 5 years ago

  • Subject changed from Wrong Error Message/Return code getting after exceeding the 'failed_login_attempts_limit' to Wrong Error Message/Return code getting after exceeding the 'failed_login_attempts_limit'

This doesn't only affect hammer but all methods. This was caused by refactoring in https://projects.theforeman.org/issues/26887

Actions
Copy link
 #2

Updated by Tomer Brisker about 5 years ago

  • Difficulty set to trivial
Actions
Copy link
 #3

Updated by Tomer Brisker about 5 years ago

  • Related to Feature #26887: graphql login: count login failures as brute force attempts added
Actions
Copy link
 #4

Updated by Dominik Matoulek about 5 years ago

  • Assignee set to Dominik Matoulek
Actions
Copy link
 #5

Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7405 added
Actions
Copy link
 #6

Updated by The Foreman Bot about 5 years ago

  • Fixed in Releases 2.0.0 added
Actions
Copy link
 #7

Updated by Dominik Matoulek about 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #8

Updated by The Foreman Bot about 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7423 added
Actions
Copy link
 #9

Updated by The Foreman Bot about 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7424 added
Actions
Copy link
 #10

Updated by Tomer Brisker about 5 years ago

  • Fixed in Releases 1.23.2, 1.24.3 added
Actions
Copy link
 #11

Updated by Tomer Brisker almost 5 years ago

  • Subject changed from Wrong Error Message/Return code getting after exceeding the 'failed_login_attempts_limit' to Wrong Error Message/Return code getting after exceeding the 'failed_login_attempts_limit'
Actions
Copy link

Also available in: Atom PDF