Project

General

Profile

Bug #29281

On upgrade dynflowd is not stopped

Added by Ewoud Kohl van Wijngaarden 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:

Description

When upgrading from Foreman 1.24 to 2.0, the dynflowd service is still running. I would expect that the foreman RPM makes sure the service is stopped since the unit file is no longer shipped.

Note it's not possible to stop a service after its unit file has been removed:

[root@pipeline-foreman-server-1-24-centos7 ~]# systemctl --no-reload disable --now dynflowd
Failed to execute operation: No such file or directory
[root@pipeline-foreman-server-1-24-centos7 ~]# systemctl status dynflowd
● dynflowd.service
   Loaded: not-found (Reason: No such file or directory)
   Active: active (running) since Fri 2020-03-06 14:52:43 UTC; 1h 17min ago
   CGroup: /system.slice/dynflowd.service
           ├─20590 dynflow_executor_monitor
           └─20596 dynflow_executor

It can also be seen that a foreman-tasks.service remains as a dangling symlink:

[root@pipeline-foreman-server-1-24-centos7 ~]# ls -l /etc/systemd/system/foreman-tasks.service 
lrwxrwxrwx. 1 root root 40 Mar  6 14:52 /etc/systemd/system/foreman-tasks.service -> /usr/lib/systemd/system/dynflowd.service

Associated revisions

Revision abeca761 (diff)
Added by Eric Helms 4 months ago

Fixes #29281: Stop dynflowd service before removal

Revision 3757af14 (diff)
Added by Ewoud Kohl van Wijngaarden 4 months ago

Fixes #29281 - Forcefully remove dynflowd.service

The dynflowd.service was removed in Foreman 2.0 by just dropping the
.service file which meansthe service keeps running.

History

#1 Updated by Ewoud Kohl van Wijngaarden 5 months ago

  • Description updated (diff)

#2 Updated by Ewoud Kohl van Wijngaarden 5 months ago

  • Description updated (diff)

#3 Updated by Anonymous 5 months ago

Same with DEBs:

lrwxrwxrwx 1 root root   36 Dec 12  2017 ruby-foreman-tasks.service -> /lib/systemd/system/dynflowd.service

#4 Updated by The Foreman Bot 5 months ago

  • Assignee set to Eric Helms
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-packaging/pull/4915 added

#5 Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/4920 added

#6 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.1.0 added

#7 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Fixed in Releases 2.0.0 added
  • Fixed in Releases deleted (2.1.0)

#8 Updated by Eric Helms 4 months ago

  • Status changed from Ready For Testing to Closed

#9 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/4947 added

#10 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.1.0 added

#11 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Fixed in Releases deleted (2.1.0)

Also available in: Atom PDF