Project

General

Profile

Actions

Refactor #29292

closed

deprecate per_page_options and move its logic to Pagination component

Added by Amir Fefer almost 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

we don't use per_page_options anywhere else (expect Pagination component), and since we already read the per_page url parameter in the pagination, it makes sense to move the logic of calculating the options into the component instead of app_metadata in application helper


Related issues 1 (0 open1 closed)

Related to Katello - Refactor #31409: Update usePaginationOptions to use hook instead of contextClosedTomer BriskerActions
Actions #1

Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Amir Fefer
  • Pull request https://github.com/theforeman/foreman/pull/7497 added
Actions #2

Updated by The Foreman Bot over 3 years ago

  • Status changed from Ready For Testing to New
  • Pull request deleted (https://github.com/theforeman/foreman/pull/7497)
Actions #3

Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8152 added
Actions #4

Updated by Tomer Brisker about 3 years ago

  • Related to Refactor #31409: Update usePaginationOptions to use hook instead of context added
Actions #5

Updated by The Foreman Bot about 3 years ago

  • Fixed in Releases 2.4.0 added
Actions #6

Updated by Tomer Brisker about 3 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF