Refactor #29292
deprecate per_page_options and move its logic to Pagination component
Pull request:
Fixed in Releases:
Found in Releases:
Description
we don't use per_page_options anywhere else (expect Pagination component), and since we already read the per_page url parameter in the pagination, it makes sense to move the logic of calculating the options into the component instead of app_metadata in application helper
Related issues
Associated revisions
History
#1
Updated by The Foreman Bot over 1 year ago
Updated by - Assignee set to Amir Fefer
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7497 added
#2
Updated by The Foreman Bot 8 months ago
- Status changed from Ready For Testing to New
- Pull request deleted (
https://github.com/theforeman/foreman/pull/7497)
#3
Updated by The Foreman Bot 8 months ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8152 added
#4
Updated by Tomer Brisker 8 months ago
Updated by - Related to Refactor #31409: Update usePaginationOptions to use hook instead of context added
#5
Updated by The Foreman Bot 8 months ago
- Fixed in Releases 2.4.0 added
#6
Updated by Tomer Brisker 8 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|8bff4054b83ff56fdcb29abcc2384a0e7977a9ba.
Fixes #29292 - Move pagination options to the client (#8152)
There is no need to send the pagination options from the server, they
can be generated on the client side.
Renamed PaginationHelper to PaginationHooks and removed test that is no
longer needed.
The pagination component already gets the pagination options and doesn't
need them to be passed in from the calling component.
Co-authored-by: Amir Fefer <amirfefer@gmail.com>