Actions
Refactor #29292
closed
deprecate per_page_options and move its logic to Pagination component
Description
we don't use per_page_options anywhere else (expect Pagination component), and since we already read the per_page url parameter in the pagination, it makes sense to move the logic of calculating the options into the component instead of app_metadata in application helper
Updated by The Foreman Bot almost 5 years ago
- Status changed from New to Ready For Testing
- Assignee set to Amir Fefer
- Pull request https://github.com/theforeman/foreman/pull/7497 added
Updated by The Foreman Bot about 4 years ago
- Status changed from Ready For Testing to New
- Pull request deleted (
https://github.com/theforeman/foreman/pull/7497)
Updated by The Foreman Bot about 4 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8152 added
Updated by Tomer Brisker about 4 years ago
- Related to Refactor #31409: Update usePaginationOptions to use hook instead of context added
Updated by Tomer Brisker about 4 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|8bff4054b83ff56fdcb29abcc2384a0e7977a9ba.
Actions