Refactor #29292
closed
deprecate per_page_options and move its logic to Pagination component
Added by Amir Fefer about 5 years ago.
Updated over 4 years ago.
Category:
JavaScript stack
|
Description
we don't use per_page_options anywhere else (expect Pagination component), and since we already read the per_page url parameter in the pagination, it makes sense to move the logic of calculating the options into the component instead of app_metadata in application helper
- Status changed from New to Ready For Testing
- Assignee set to Amir Fefer
- Pull request https://github.com/theforeman/foreman/pull/7497 added
- Status changed from Ready For Testing to New
- Pull request deleted (
https://github.com/theforeman/foreman/pull/7497)
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8152 added
- Related to Refactor #31409: Update usePaginationOptions to use hook instead of context added
- Fixed in Releases 2.4.0 added
- Status changed from Ready For Testing to Closed
Also available in: Atom
PDF