Refactor #29378: Fix DHCP conflicts on requests without hardware_type - Smart Proxy - Foreman

Actions

Copy link

Refactor #29378

open

Fix DHCP conflicts on requests without hardware_type

Added by Lukas Zapletal about 4 years ago. Updated about 4 years ago.

Status:

Ready For Testing

Priority:

Normal

Assignee:

Lukas Zapletal

Category:

DHCP

Target version:

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/theforeman/smart-proxy/pull/753

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Equality of DHCP records is poorly defined as arbitrary hash named "options" is used. Various implementations parse/fetch various DHCP options into the hash while SmartProxy DHCP API only defines few options (hostname, filename, ip, mac). In the reported problem, ISC DHCP configuration file parser also adds "hardware_type" option (set to "ethernet") while newly created DHCP record don't have this option. Comparsion of the two same DHCP records fails which lead to DHCP conflict.

The solution is either to add hardware_type to all DHCP Record instances for ISC DHCP or to remove it when data is parsed, because only "ethernet" hardware type is supported at the moment. This is hardcoded in the code, therefore I lean towards the latter solution.