Project

General

Profile

Refactor #29463

Drop webrick patch

Added by Ewoud Kohl van Wijngaarden 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
SSL
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

In #12572 (508a9e8b18d8811f65f0f9f4201c287bae55da2d) a webrick patch was added to support setting ciphers. This is a copy of the built in method which means it gets out of date. Ruby 2.4 added the SSLCiphers option so this workaround is no longer needed.


Related issues

Related to foreman-tasks - Refactor #29622: Drop webrick patchClosed

Associated revisions

Revision 94a84f10 (diff)
Added by Ewoud Kohl van Wijngaarden 4 months ago

Fixes #29463 - Drop webrick patch

In 508a9e8b18d8811f65f0f9f4201c287bae55da2d a webrick patch was added to
support setting ciphers. This is a copy of the built in method which
means it gets out of date. Ruby 2.4 added the SSLCiphers option so this
workaround is no longer needed.

As an example, the built in Ruby has correctly updated the automatic
self signed certificate to 2048 bits. It also supports Server Name
Indication.

History

#1 Updated by The Foreman Bot 4 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/756 added

#2 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.1.0 added

#3 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Ewoud Kohl van Wijngaarden 3 months ago

Also available in: Atom PDF