Project

General

Profile

Refactor #29474

Tracker #24837: Rails 6.0 Tracker

remove :on from save/update/create/destroy callbacks

Added by Tomer Brisker 7 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Looks like they were silently ignored previously but raise an error in rails 6: https://github.com/rails/rails/pull/30919

Associated revisions

Revision c12d8a8e (diff)
Added by Tomer Brisker 7 months ago

Fixes #29474 - remove :on from save callbacks

This was silently ignored, and will fail in rails 6. Changing the
callbacks to the correct ones intended according to the :on option.

History

#1 Updated by Tomer Brisker 7 months ago

  • Status changed from New to Closed

#2 Updated by The Foreman Bot 7 months ago

  • Assignee set to Ondřej Ezr
  • Pull request https://github.com/theforeman/foreman/pull/7567 added

#3 Updated by Tomer Brisker 5 months ago

  • Fixed in Releases 2.1.0 added

Also available in: Atom PDF