Refactor #29483
Remove usage of Class level methods scope inheritance
Related issues
Associated revisions
History
#1
Updated by Ondřej Ezr almost 3 years ago
- Blocks Tracker #28570: Rails 6.1 Tracker added
#2
Updated by The Foreman Bot almost 3 years ago
- Assignee set to Ondřej Ezr
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7575 added
#3
Updated by Anonymous almost 3 years ago
- Related to Refactor #29647: Remove usage of Class level methods scope inheritance added
#4
Updated by Ewoud Kohl van Wijngaarden 7 months ago
One commit was merged into Foreman 2.1.0 but this is still open since it was Refs. Can it be closed or is there still work remaining?
#5
Updated by Ondřej Ezr 7 months ago
Yes, I believe so, many improvements were merged since then, I remember Tomer and Leos had touched that and I believe with Rails 6.2 we were forced to do it properly.
So if everything works with Rails 6.2, lets close.
#6
Updated by Ondřej Ezr 7 months ago
- Status changed from Ready For Testing to Resolved
- Fixed in Releases 3.4.0 added
Setting fixed in release on 3.4, but 3.3 would be more appropriate for sure, but it is already closed relase.
Refs #29483 - remove unecessary use of implicit scopes