Project

General

Profile

Actions
Copy link

Bug #29484

closed

after_build hook is executed at the wrong host creation stage

Added by Bernhard Suttner about 4 years ago. Updated about 4 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Bernhard Suttner
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7570
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Current:

def build_hooks
return if previous_changes['build'].nil?
if build?
run_callbacks :build do

build? is true! if the host IS in build stage. But, after_build should be the point in time, when the build is finished - so if build was set from true to false. Currently, before_provision and after_build are mixed up.

Actions
Copy link
 #1

Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Bernhard Suttner
  • Pull request https://github.com/theforeman/foreman/pull/7570 added
Actions
Copy link
 #2

Updated by Bernhard Suttner about 4 years ago

  • Status changed from Ready For Testing to Rejected

I came to the conclusion, that the sequence is fine. Sorry for opening the issue.

Actions
Copy link

Also available in: Atom PDF