Project

General

Profile

Actions

Refactor #29491

closed

simplify Plugin#pending_migration method

Added by Tomer Brisker almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

the method currently uses activerecord migration internals to get a list of pending migrations that is only used for debug logging. The internals changed in rails 6 requiring a change to this method but it can be simplified so it doesn't rely on the internal methods.

Actions #1

Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/7571 added
Actions #2

Updated by The Foreman Bot almost 4 years ago

  • Fixed in Releases 2.1.0 added
Actions #3

Updated by Tomer Brisker almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF