Actions
Bug #29496
closedRelying on query string parsing breaks client-side pagination
Description
Pagination component directly calls helpers to parse page url and if 'perPage' is not found in query string, it uses default page size from settings with no option to override via props. This makes the component very inflexible as it is now tied to browser url. As a side effect, this breaks client-side pagination on pages where Pagination component is used.
Steps to reproduce:
1) sync templates using foreman_templates plugin
2) change number of entries per page when sync result is displayed
3) the correct number of entries is displayed, but pagination shows incorrect numbers
Updated by Ondřej Pražák almost 5 years ago
- Related to Feature #28148: Add react context provider added
Updated by The Foreman Bot almost 5 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7573 added
Updated by Ondřej Pražák almost 5 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset 8dd04ca8c36ec6b9574209bfd27765edc5332568.
Actions