Project

General

Profile

Bug #29496

Relying on query string parsing breaks client-side pagination

Added by Ondřej Pražák 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Pagination component directly calls helpers to parse page url and if 'perPage' is not found in query string, it uses default page size from settings with no option to override via props. This makes the component very inflexible as it is now tied to browser url. As a side effect, this breaks client-side pagination on pages where Pagination component is used.

Steps to reproduce:
1) sync templates using foreman_templates plugin
2) change number of entries per page when sync result is displayed
3) the correct number of entries is displayed, but pagination shows incorrect numbers


Related issues

Related to Foreman - Feature #28148: Add react context provider Closed

Associated revisions

Revision 8dd04ca8 (diff)
Added by Ondřej Pražák 4 months ago

Fixes #29496 - Fix pagination for client-side paging

History

#1 Updated by Ondřej Pražák 4 months ago

#2 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7573 added

#3 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.1.0 added

#4 Updated by Ondřej Pražák 4 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Amit Upadhye 3 months ago

  • Category set to JavaScript stack

Also available in: Atom PDF