Project

General

Profile

Actions
Copy link

Refactor #29539

closed

Unbundle websockify

Added by Ewoud Kohl van Wijngaarden about 4 years ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Packaging
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/9392, https://github.com/theforeman/foreman-packaging/pull/8424, https://github.com/theforeman/foreman-packaging/pull/8425, https://github.com/theforeman/foreman-packaging/pull/10053, https://github.com/theforeman/foreman-packaging/pull/10197
Fixed in Releases:
3.5.0
Found in Releases:
Red Hat JIRA:

Description

Current Foreman ships a bundled websockify implementation. cdd8424fb4d31b390531cc1a1d74fb3820bae31a suggests it was updated to 1.6.1 but https://github.com/novnc/websockify/releases suggests the newest version is 0.9.0.

Foreman should depend on this and use an installed version from $PATH.

https://community.theforeman.org/t/consolidating-the-console/11215 also spoke about a bigger refactor which can be related, but unbundling might make that easier to achieve.

Actions
Copy link
 #1

Updated by Lukas Zapletal about 4 years ago

SELinux changes will likely be needed after this change. Let me know if you run into issues.

Actions
Copy link
 #2

Updated by Ewoud Kohl van Wijngaarden about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/foreman/pull/9392 added
Actions
Copy link
 #4

Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/8424 added
Actions
Copy link
 #5

Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/8425 added
Actions
Copy link
 #6

Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases 3.5.0 added
Actions
Copy link
 #7

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #8

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Category set to Packaging
  • Triaged changed from No to Yes
Actions
Copy link
 #9

Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/10053 added
Actions
Copy link
 #10

Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/10197 added
Actions
Copy link

Also available in: Atom PDF