Project

General

Profile

Actions

Refactor #29539

closed

Unbundle websockify

Added by Ewoud Kohl van Wijngaarden over 4 years ago. Updated 10 months ago.


Description

Current Foreman ships a bundled websockify implementation. cdd8424fb4d31b390531cc1a1d74fb3820bae31a suggests it was updated to 1.6.1 but https://github.com/novnc/websockify/releases suggests the newest version is 0.9.0.

Foreman should depend on this and use an installed version from $PATH.

https://community.theforeman.org/t/consolidating-the-console/11215 also spoke about a bigger refactor which can be related, but unbundling might make that easier to achieve.


Related issues 1 (0 open1 closed)

Related to SELinux - Bug #37791: websockify doesn't work with SELinux enabledClosedEvgeni GolovActions
Actions #1

Updated by Lukas Zapletal over 4 years ago

SELinux changes will likely be needed after this change. Let me know if you run into issues.

Actions #2

Updated by Ewoud Kohl van Wijngaarden over 4 years ago

  • Description updated (diff)
Actions #3

Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/foreman/pull/9392 added
Actions #4

Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/8424 added
Actions #5

Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/8425 added
Actions #6

Updated by The Foreman Bot about 2 years ago

  • Fixed in Releases 3.5.0 added
Actions #7

Updated by Ewoud Kohl van Wijngaarden about 2 years ago

  • Status changed from Ready For Testing to Closed
Actions #8

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Category set to Packaging
  • Triaged changed from No to Yes
Actions #9

Updated by The Foreman Bot 11 months ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/10053 added
Actions #10

Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/10197 added
Actions #11

Updated by Evgeni Golov about 1 month ago

  • Related to Bug #37791: websockify doesn't work with SELinux enabled added
Actions

Also available in: Atom PDF