Project

General

Profile

Refactor #29539

Unbundle websockify

Added by Ewoud Kohl van Wijngaarden over 2 years ago. Updated 21 days ago.

Status:
Closed
Priority:
Normal
Category:
Packaging
Target version:
-

Description

Current Foreman ships a bundled websockify implementation. cdd8424fb4d31b390531cc1a1d74fb3820bae31a suggests it was updated to 1.6.1 but https://github.com/novnc/websockify/releases suggests the newest version is 0.9.0.

Foreman should depend on this and use an installed version from $PATH.

https://community.theforeman.org/t/consolidating-the-console/11215 also spoke about a bigger refactor which can be related, but unbundling might make that easier to achieve.

Associated revisions

Revision 20f48047 (diff)
Added by Ewoud Kohl van Wijngaarden 3 months ago

Fixes #29539 - Unbundle websockify

Removing the outdated websockify version means relying on the system
version. This allows independent (security) updates.

It is now expected that websockify lives somewhere in $PATH.

Revision 27e3511e (diff)
Added by Ewoud Kohl van Wijngaarden 3 months ago

Refs #29539 - Depend on websockify if needed

Websockify used to be vendored to show a console for some compute
resources:

$ rg -i wsproxy.start -l
app/models/compute_resources/foreman/model/ovirt.rb
app/models/compute_resources/foreman/model/vmware.rb
app/models/compute_resources/foreman/model/libvirt.rb

Now it's using a proper package.

Revision 5001247d (diff)
Added by Ewoud Kohl van Wijngaarden 3 months ago

Refs #29539 - Depend on websockify if needed

Websockify used to be vendored to show a console for some compute
resources:

$ rg -i wsproxy.start -l
app/models/compute_resources/foreman/model/ovirt.rb
app/models/compute_resources/foreman/model/vmware.rb
app/models/compute_resources/foreman/model/libvirt.rb

Now it's using a proper package.

History

#1 Updated by Lukas Zapletal over 2 years ago

SELinux changes will likely be needed after this change. Let me know if you run into issues.

#2 Updated by Ewoud Kohl van Wijngaarden over 2 years ago

  • Description updated (diff)

#3 Updated by The Foreman Bot 3 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9392 added

#4 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/8424 added

#5 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/8425 added

#6 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.5.0 added

#7 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Status changed from Ready For Testing to Closed

#8 Updated by Ewoud Kohl van Wijngaarden 21 days ago

  • Triaged changed from No to Yes
  • Category set to Packaging

Also available in: Atom PDF