Bug #29591
Efibootmgr_netboot assumes bash is used.
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Templates
Target version:
-
Difficulty:
Triaged:
No
Description
During testing with debian deployment on EFI hosts, we noticed that the /tmp/finish.sh throws an error: in-target: /tmp/finish.sh: 325: /tmp/finish.sh: [[: not found. This is caused by provisioning_templates/snippet/efibootmgr_netboot.erb which uses double brackets when testing for efi. Replacing the test cases with single brackets will make efibootmgr_netboot compliant with sh.
The fix for this has been pushed into develop branch, however fixing this in the stable branches should be considered. I've attached a patch based on 1.24-stable which fixes the issue. Please let me know if you need anything else.
--BtH
Associated revisions
History
#1
Updated by The Foreman Bot almost 3 years ago
Updated by - Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/community-templates/pull/719 added
#2
Updated by The Foreman Bot almost 3 years ago
- Fixed in Releases 2.1.0 added
#3
Updated by Ben ter Haar almost 3 years ago
Updated by - Status changed from Ready For Testing to Closed
Applied in changeset community-templates|4c11d0529156ee9993b72fa6d6f71e6b5cb8a66b.
#4
Updated by Ewoud Kohl van Wijngaarden almost 3 years ago
Updated by - Category set to Templates
- Fixed in Releases 1.24.3, 2.0.1 added
Fixes #29591 - Replaced the double bracket testing to builtin test
Depending on the active shell, the efibootmgr_netboot snippet will throw
an error in the finish.sh script like
/tmp/finish.sh: 325: /tmp/finish.sh: [[: not found