Project

General

Profile

Bug #29591

Efibootmgr_netboot assumes bash is used.

Added by Ben ter Haar 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Templates
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

During testing with debian deployment on EFI hosts, we noticed that the /tmp/finish.sh throws an error: in-target: /tmp/finish.sh: 325: /tmp/finish.sh: [[: not found. This is caused by provisioning_templates/snippet/efibootmgr_netboot.erb which uses double brackets when testing for efi. Replacing the test cases with single brackets will make efibootmgr_netboot compliant with sh.

The fix for this has been pushed into develop branch, however fixing this in the stable branches should be considered. I've attached a patch based on 1.24-stable which fixes the issue. Please let me know if you need anything else.

--BtH

fix_efibootmgr_netboot.patch fix_efibootmgr_netboot.patch 1.4 KB Patch based on 1.24-stable Ben ter Haar, 04/22/2020 09:40 AM

Associated revisions

Revision 4c11d052 (diff)
Added by Ben ter Haar 5 months ago

Fixes #29591 - Replaced the double bracket testing to builtin test

Depending on the active shell, the efibootmgr_netboot snippet will throw
an error in the finish.sh script like
/tmp/finish.sh: 325: /tmp/finish.sh: [[: not found

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/community-templates/pull/719 added

#2 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases 2.1.0 added

#3 Updated by Ben ter Haar 5 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Ewoud Kohl van Wijngaarden 5 months ago

  • Category set to Templates
  • Fixed in Releases 1.24.3, 2.0.1 added

Also available in: Atom PDF