Project

General

Profile

Actions

Bug #29594

closed

Tasks uses wrong controller name for bookmarks

Added by Adam Ruzicka about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1826734

Description of problem:
Version of tasks in 6.7 uses 'foreman_tasks/tasks' as controller name for bookmarks, but Satellites <6.7 used 'foreman_tasks_tasks'.

This has several outcomes:
1) The user cannot see the default bookmarks we ship
2) The user can CRUD new bookmarks, we will need to take care of this when fixing this.
3) If the user upgraded from previous release, they won't be able to see any of their old bookmarks.

Version-Release number of selected component (if applicable):
tfm-rubygem-foreman-tasks-0.17.5.2-1.el7sat.noarch

How reproducible:
Always

Steps to Reproduce:
1. Go to tasks index
2. Run the following on satelltie to get counts of bookmarks
foreman-rake console <<EOF
%w(_ /).each do |separator|
controller = 'foreman_tasks' + separator + 'tasks'
puts "#{controller}: #{Bookmark.where(:controller => controller).count}"
end
EOF

3. Click the bookmark button next to the search bar
4. Create a new bookmark
5. Rerun command from 2.

Actual results:
There are no bookmarks in step 3, although data from step 2 say there should be some. In the output of step 5, we can see the number of bookmarks assigned with foreman_tasks/tasks goes up.

Expected results:
Bookmarks we ship and bookmarks user created before upgrade are shown there. In the output of step 5, we can see the number of bookmarks assigned with foreman_tasks_tasks goes up, foreman_tasks/tasks is zero.

Actions #1

Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ron Lavi
  • Pull request https://github.com/theforeman/foreman-tasks/pull/545 added
Actions #2

Updated by The Foreman Bot about 5 years ago

  • Fixed in Releases foreman-tasks-1.1.2 added
Actions #3

Updated by Ron Lavi about 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Adam Ruzicka about 5 years ago

  • Subject changed from Tasks uses wrong controller name for bookmarks to Tasks uses wrong controller name for bookmarks
  • Fixed in Releases foreman-tasks-2.0.0 added
  • Fixed in Releases deleted (foreman-tasks-1.1.2)
Actions

Also available in: Atom PDF