Project

General

Profile

Refactor #2961

Add foreman specific adapter

Added by Martin Bacovsky almost 6 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Currently certain foreman specific field types have formatters in base adapter. It would be cleaner to have Foreman specific adapter with this formatters in hammer-cli-foreman.

Formatters that are now implemented as methods of BaseAdapter can be turned into classes and shared across multiple adapters.

Associated revisions

Revision 7ca751dc (diff)
Added by Martin Bacovsky over 5 years ago

fixes #2961 - Refactoring of output and formatters

Revision f54d0dbe (diff)
Added by Martin Bacovsky over 5 years ago

fixes #2961 - Refactoring of output and formatters

Revision f6127440
Added by Tomas Strachota over 5 years ago

Merge pull request #29 from mbacovsky/2961_output_refactoring

fixes #2961 - Refactoring of output and formatters

History

#1 Updated by Tomáš Strachota almost 6 years ago

  • Assignee set to Tomáš Strachota

#2 Updated by Tomáš Strachota over 5 years ago

  • Assignee deleted (Tomáš Strachota)

#3 Updated by Tomáš Strachota over 5 years ago

  • Description updated (diff)

#4 Updated by Tomáš Strachota over 5 years ago

  • Target version changed from 1.3.0 to 1.4.0

#5 Updated by Martin Bacovsky over 5 years ago

  • Status changed from New to Assigned
  • Assignee set to Martin Bacovsky

I found out, that adding new adapters would be difficult to maintain co I made them more configurable. Formatters were moved to classes and the Foreman specific ones were moved to hammer-cli-foreman.

#7 Updated by Martin Bacovsky over 5 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset hammer-cli|commit:7ca751dc41f42cfaa55c4e3160b1d5207bff4c8e.

#8 Updated by Greg Sutcliffe over 5 years ago

  • Legacy Backlogs Release (now unused) set to 2

#9 Updated by Dominic Cleal over 5 years ago

  • Project changed from Foreman to Hammer CLI
  • Category deleted (44)

Also available in: Atom PDF