Project

General

Profile

Bug #29614

Search in Template editor doesn't work at all

Added by Marcel K├╝hlhorn over 1 year ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
Templates
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When searching for a variable or parameter in a template with CTRL+F the search only covers the currently visible part of the template, it should search in the whole template

Associated revisions

Revision 2d8b1bbc (diff)
Added by Maria Agaphontzev 6 months ago

Fixes #29614 - add search to ace editor

History

#1 Updated by Bernhard Suttner 7 months ago

  • Found in Releases 2.3.0 added

The search functionality doesn't work in foreman 2.3, too. Did you already recognize this?

#2 Updated by Bernhard Suttner 7 months ago

  • Assignee set to Avi Sharvit

Currently I see, that the search functionality in the templates editor is completely unusable. No search box is even shown.

#3 Updated by Bernhard Suttner 7 months ago

  • Found in Releases 2.2.0, 2.4.0 added

#4 Updated by Bernhard Suttner 7 months ago

  • Subject changed from Search in Template editor only works for currently visible part to Search in Template editor doesn't work at all

#5 Updated by Bernhard Suttner 6 months ago

I tried:
- to add ace-builds so that "import 'ace-builds/src-min-noconflict/ext-searchbox';" works. Issue "ace.require is not a function" see https://github.com/securingsincity/react-ace/issues/722
- to replace react-ace with https://www.npmjs.com/package/react-ace-builds - search box is still not shown.

#6 Updated by Maria Agaphontzev 6 months ago

  • Assignee changed from Avi Sharvit to Maria Agaphontzev

Currently to work around a user can open the ace editor in full screen and then the browser search works there. (using the maximize button)

#7 Updated by Maria Agaphontzev 6 months ago

  • Bugzilla link set to 1971072

added a related bz, not completely the same bug

#8 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8621 added

#9 Updated by The Foreman Bot 6 months ago

  • Fixed in Releases 3.0.0 added

#10 Updated by Maria Agaphontzev 6 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF