Foreman Maintain

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1827219

The "disk-performance" check present in the foreman-maintain is showing inconsistent results while performing satellite version upgrade.

Here is the output shared by a customer using Fiber channel based SAN storage on Satellite server:

====
Disk speed : 22 MB/sec [WARNING]
Slow disk detected /var/lib/pulp mounted on /dev/mapper/sat--server-sat--server--lv.
Actual disk speed: 22 MB/sec
Expected disk speed: 60 MB/sec.
WARNING: Low disk speed might have a negative impact on the system. ====

The same concern is raised by other customers using SSD local disk.

This warning message creates confusion for customers and they report a support case to confirm whether they should be worried about it or not. In those support cases, we have to tell customers to ignore the warning and use --whitelist="disk-performance" option with foreman-maintain to complete the upgrade.

This check was important when we changed the directory structure of /var/lib/pulp/ in Satellite 6.3 but in recent releases, we are not making any such filesystem level movements. So to avoid the confusion for customer it would be better to hide the check.