Bug #2976
Reports page not showing when an Error was returned
Description
The Hosts view shows an [E] status of the last host's run status, however, the reports view/page doesn't show that error (only inside the actual report itself).
| foreman_1.png | View foreman_1.png | 3.17 KB | |||
| foreman_2.png | View foreman_2.png | 6.75 KB | |||
| foreman_3.png | View foreman_3.png | 8.53 KB |
Related issues
History
#1
Updated by Greg Sutcliffe over 9 years ago
Updated by We actually have a specific unit test for this type of report, to check that Foreman sets the error state on the Host correctly. This is because Puppet will send a report with no metrics in it, so the numbers are all zeros (i.e. there are no errors because no resources were in error state).
I'm just in the middle of moving the report handling logic to the report processor (i.e. building a JSON hash for Foreman to import) - there's no reason we couldn't extend it to try to detect this case and inject a single error metric. However, that feels a little bit clunky and fragile. Thoughts?
#2
Updated by Dominic Cleal over 9 years ago
Updated by - Status changed from New to Feedback
Digging into this a little, I can't see why this wouldn't work as-is. The error status of the host in Foreman comes from either "failed" or "failed_restarts" being non-zero, which means it should show up in the appropriate columns on the reports list.
Are you sure you're looking at reports from the right host?
A host on our own Foreman instance has a catalog build failure at the moment, shows up in an error state and shows a single "failure" event on the reports list. It's running Puppet 2.7.21 for reference.
#3
Updated by Alex Leonhardt over 9 years ago
Updated by Hi, yes, I'm 100% sure :) ... for obvious reasons I cant just post the whole page / screen here, but it definitely does not show up as Error in the reports if the catalog wasnt able to compile. It does show in the hosts list though. We're running puppet 3.0.2 at the moment and foreman 1.1 if that helps ?
Alex
#4
Updated by Dominic Cleal over 9 years ago
- Related to Bug #3851: Reports with errors on the puppet master side are not shown as failed added
#5
Updated by Benjamin Papillon about 9 years ago
Updated by - Status changed from Feedback to New
#6
Updated by Anonymous over 8 years ago
how is this different to #3851?
#7
Updated by Dominic Cleal over 8 years ago
- Status changed from New to Duplicate
I think it probably is the same, so was only recently fixed. Please let us know if it recurs with the current report processor.