Project

General

Profile

Actions
Copy link

Feature #29811

open

Add execute helpers to hooks

Added by Eric Helms about 4 years ago. Updated almost 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

https://github.com/theforeman/foreman-installer/blob/develop/hooks/boot/01-kafo-hook-extensions.rb#L86 and https://github.com/theforeman/foreman-installer/blob/develop/hooks/boot/01-kafo-hook-extensions.rb#L99

Related issues 1 (1 open — 0 closed)

Blocks Installer - Refactor #27371: Move Installer hook helpers to Kafo where they make senseNewActions
Actions
Copy link
 #1

Updated by Ewoud Kohl van Wijngaarden about 4 years ago

When highlighting lines, you should really use the permanent URLs. Line numbers shift when changes are made. The easiest way in Github is by pressing y. This changes it into https://github.com/theforeman/foreman-installer/blob/826d106b529018f5682bf51ad79172cf1f518f3b/hooks/boot/01-kafo-hook-extensions.rb#L94. You can already now see that line 86 shifted to 94. By linking to a specific commit rather than the branch, you're guaranteed it'll never shift. I think line 99 was actually https://github.com/theforeman/foreman-installer/blob/826d106b529018f5682bf51ad79172cf1f518f3b/hooks/boot/01-kafo-hook-extensions.rb#L107

Actions
Copy link
 #2

Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

  • Tracker changed from Refactor to Feature
  • Project changed from Installer to Kafo
  • Subject changed from Add execute to Kafo hooks to Add execute helpers to hooks
  • Parent task deleted (#27371)
  • Triaged changed from No to Yes
Actions
Copy link
 #3

Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

  • Blocks Refactor #27371: Move Installer hook helpers to Kafo where they make sense added
Actions
Copy link

Also available in: Atom PDF