Project

General

Profile

Bug #29894

Success file is written, even if the installer failed

Added by Ewoud Kohl van Wijngaarden 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
foreman-installer script
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:

Description

When the installer is ran but failed, the success file is written. On the next run, the success file exists so the initial credentials are not shown.

This was found on 2.1.0-RC1 but can be traced to 540638cd3bc295a0f857f87b89863af5db8558b9 (#29243) which was picked to 2.0-stable.


Related issues

Related to Installer - Bug #29243: New install message shown every timeClosed

Associated revisions

Revision 284a71cc (diff)
Added by Ewoud Kohl van Wijngaarden 4 months ago

Fixes #29894 - Only write the success file on success

540638cd3bc295a0f857f87b89863af5db8558b9 introduced a success file, but
it's written regardless of success. When the first run fails, the user
doesn't see initial credentials on the second (successful) run.

History

#1 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Related to Bug #29243: New install message shown every time added

#2 Updated by The Foreman Bot 4 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-installer/pull/506 added

#3 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Triaged changed from No to Yes
  • Target version set to 2.1.0

This should be fixed in 2.1.0 and picked into 2.0.1.

#4 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.2.0 added

#5 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Tomer Brisker 4 months ago

  • Target version changed from 2.1.0 to 2.0.1

#7 Updated by Tomer Brisker 4 months ago

  • Fixed in Releases 2.0.1, 2.1.0 added
  • Fixed in Releases deleted (2.2.0)

Also available in: Atom PDF