Bug #29894
Success file is written, even if the installer failed
Status:
Closed
Priority:
Normal
Assignee:
Category:
foreman-installer script
Target version:
Fixed in Releases:
Found in Releases:
Description
When the installer is ran but failed, the success file is written. On the next run, the success file exists so the initial credentials are not shown.
This was found on 2.1.0-RC1 but can be traced to 540638cd3bc295a0f857f87b89863af5db8558b9 (#29243) which was picked to 2.0-stable.
Related issues
Associated revisions
History
#1
Updated by Ewoud Kohl van Wijngaarden 10 months ago
Updated by - Related to Bug #29243: New install message shown every time added
#2
Updated by The Foreman Bot 10 months ago
Updated by - Assignee set to Ewoud Kohl van Wijngaarden
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman-installer/pull/506 added
#3
Updated by Ewoud Kohl van Wijngaarden 10 months ago
- Triaged changed from No to Yes
- Target version set to 2.1.0
This should be fixed in 2.1.0 and picked into 2.0.1.
#4
Updated by The Foreman Bot 10 months ago
- Fixed in Releases 2.2.0 added
#5
Updated by Ewoud Kohl van Wijngaarden 10 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset installer|284a71cc20b20e4d6686c7bdbd025154c9c2ad12.
#6
Updated by Tomer Brisker 9 months ago
Updated by - Target version changed from 2.1.0 to 2.0.1
#7
Updated by Tomer Brisker 9 months ago
- Fixed in Releases 2.0.1, 2.1.0 added
- Fixed in Releases deleted (
2.2.0)
Fixes #29894 - Only write the success file on success
540638cd3bc295a0f857f87b89863af5db8558b9 introduced a success file, but
it's written regardless of success. When the first run fails, the user
doesn't see initial credentials on the second (successful) run.