Project

General

Profile

Refactor #30085

interval middleware should not pass action to the next middleware when stopping the interval

Added by Ron Lavi 9 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Ron Lavi
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7771, https://github.com/theforeman/foreman/pull/7738
Fixed in Releases:
2.2.0
Found in Releases:

Related issues

Related to Katello - Bug #30242: Error: There is already an interval running and registered for: SUBSCRIPTIONS_TASK_SEARCHDuplicate

Associated revisions

Revision 9582dab6 (diff)
Added by Ron Lavi 8 months ago

Fixes #30085 - return on interval middleware stop

Revision d3608094 (diff)
Added by Ron Lavi 8 months ago

Refs #30085 - pass stop_interval action to reducer

last refactor did fix the severals warnings we got
but the action actually should not be stopped in the middleware
in order of the reducer to update the state correctly
removing that interval key from state.

History

#1 Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7738 added

#2 Updated by The Foreman Bot 8 months ago

  • Fixed in Releases 2.2.0 added

#3 Updated by Ron Lavi 8 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 8 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7771 added

#5 Updated by Jonathon Turel 8 months ago

  • Related to Bug #30242: Error: There is already an interval running and registered for: SUBSCRIPTIONS_TASK_SEARCH added

#6 Updated by Tomer Brisker 7 months ago

  • Category set to JavaScript stack

#7 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7975 added

Also available in: Atom PDF