Refactor #30127
Refactor #30581: Extract fact importing from Host class to to HostFactImporter
Extract import_facts entry point from host class and create HostFactImporter
Pull request:
Fixed in Releases:
Found in Releases:
Description
The fact import is now tied with a Host model. We might want to extract it as the clas is too big and it should not be its responsibility.
Related issues
Associated revisions
Refs #30127 - drop setting enable_orchestration_on_fact_import
Fixes #30127 - always skip orchestration
bb84e41 removed the setting on bases of what we've skipped orchestration.
Without the setting, the method no longer has any use.
There are no current subclasses that could override it so the method can be dropped.
History
#1
Updated by Ondřej Ezr 4 months ago
Updated by - Related to Tracker #30128: Remove STI from Host model added
#2
Updated by The Foreman Bot 4 months ago
Updated by - Assignee set to Ondřej Ezr
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7749 added
#3
Updated by Lukas Zapletal 3 months ago
Updated by - Related to Bug #30577: Tests fail due to HostFactImporter#import_facts added
#4
Updated by Ondřej Ezr 3 months ago
- Triaged changed from No to Yes
- Difficulty set to medium
- Parent task set to #30581
- Subject changed from Extract fact import from host class to Extract import_facts entry point from host class and create HostFactImporter
#5
Updated by The Foreman Bot 3 months ago
- Pull request https://github.com/theforeman/foreman/pull/7883 added
#6
Updated by The Foreman Bot 3 months ago
- Fixed in Releases 2.2.0 added
#7
Updated by Ondřej Ezr 3 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|6caa9ffdba581b798bad3b89bc0f6f60621f12d7.
#8
Updated by The Foreman Bot about 1 month ago
- Pull request https://github.com/theforeman/foreman/pull/7975 added
Refs #30127 - extract import_facts from host