Refactor #30127: Extract import_facts entry point from host class and create HostFactImporter - Foreman

Refactor #30127

Refactor #30581: Extract fact importing from Host class to to HostFactImporter

Extract import_facts entry point from host class and create HostFactImporter

Added by Ondřej Ezr 7 months ago. Updated about 2 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Ondřej Ezr

Category:

Facts

Target version:

Difficulty:

medium

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/7883, https://github.com/theforeman/foreman/pull/7749

Fixed in Releases:

2.2.0

Found in Releases:

Description

The fact import is now tied with a Host model. We might want to extract it as the clas is too big and it should not be its responsibility.

Related issues

Associated revisions

Revision 5253d21e (diff)
Added by Ondřej Ezr 7 months ago

Refs #30127 - extract import_facts from host

Revision bb84e41d (diff)
Added by Ondřej Ezr 7 months ago

Refs #30127 - drop setting enable_orchestration_on_fact_import

Revision 6caa9ffd (diff)
Added by Ondřej Ezr 5 months ago

Fixes #30127 - always skip orchestration

bb84e41 removed the setting on bases of what we've skipped orchestration.
Without the setting, the method no longer has any use.
There are no current subclasses that could override it so the method can be dropped.

History

#1 Updated by Ondřej Ezr 7 months ago

Related to Tracker #30128: Remove STI from Host model added

#2 Updated by The Foreman Bot 7 months ago

Assignee set to Ondřej Ezr
Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/7749 added

#3 Updated by Lukas Zapletal 5 months ago

Related to Bug #30577: Tests fail due to HostFactImporter#import_facts added

#4 Updated by Ondřej Ezr 5 months ago

Triaged changed from No to Yes
Difficulty set to medium
Parent task set to #30581
Subject changed from Extract fact import from host class to Extract import_facts entry point from host class and create HostFactImporter