Project

General

Profile

Refactor #30127

Refactor #30581: Extract fact importing from Host class to to HostFactImporter

Extract import_facts entry point from host class and create HostFactImporter

Added by Ondřej Ezr 4 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Facts
Target version:
-
Difficulty:
medium
Triaged:
Yes
Bugzilla link:

Description

The fact import is now tied with a Host model. We might want to extract it as the clas is too big and it should not be its responsibility.


Related issues

Related to Foreman - Tracker #30128: Remove STI from Host modelNew

Related to Discovery - Bug #30577: Tests fail due to HostFactImporter#import_factsClosed

Associated revisions

Revision 5253d21e (diff)
Added by Ondřej Ezr 4 months ago

Refs #30127 - extract import_facts from host

Revision bb84e41d (diff)
Added by Ondřej Ezr 4 months ago

Refs #30127 - drop setting enable_orchestration_on_fact_import

Revision 6caa9ffd (diff)
Added by Ondřej Ezr 3 months ago

Fixes #30127 - always skip orchestration

bb84e41 removed the setting on bases of what we've skipped orchestration.
Without the setting, the method no longer has any use.
There are no current subclasses that could override it so the method can be dropped.

History

#1 Updated by Ondřej Ezr 4 months ago

#2 Updated by The Foreman Bot 4 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7749 added

#3 Updated by Lukas Zapletal 3 months ago

  • Related to Bug #30577: Tests fail due to HostFactImporter#import_facts added

#4 Updated by Ondřej Ezr 3 months ago

  • Triaged changed from No to Yes
  • Difficulty set to medium
  • Parent task set to #30581
  • Subject changed from Extract fact import from host class to Extract import_facts entry point from host class and create HostFactImporter

#5 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7883 added

#6 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 2.2.0 added

#7 Updated by Ondřej Ezr 3 months ago

  • Status changed from Ready For Testing to Closed

#8 Updated by The Foreman Bot about 1 month ago

  • Pull request https://github.com/theforeman/foreman/pull/7975 added

Also available in: Atom PDF