Feature #30284
Provide clearer Smart Proxy registration errors with as much context as possible based on the error
Difficulty:
Triaged:
Yes
Description
Handle the following:
* Apache can be down * Connection refused or connection timeout * Foreman can be down * HTTP 502 or 503 * Foreman can throw an error * Does not always return a proper error message * Need to check/fix Foreman to return a proper JSON structured error message * Typically a 500 * Authorization error * Show a proper invalid credentials error * Instruct users where to look for error messages * Include in error message to look in production.log when appropriate
Related issues
Associated revisions
History
#1
Updated by Eric Helms over 2 years ago
- Description updated (diff)
#2
Updated by Eric Helms over 2 years ago
- Description updated (diff)
#3
Updated by Eric Helms over 2 years ago
- Related to Bug #30285: Smart proxy registration API does not always return a structured JSON error response added
#4
Updated by Eric Helms over 2 years ago
- Pull request https://github.com/theforeman/puppet-foreman/pull/865 added
#5
Updated by Eric Helms over 2 years ago
- Target version set to 2.2.0
#6
Updated by Ewoud Kohl van Wijngaarden over 2 years ago
Noting down so I don't forget: we can also retry on some HTTP errors, like 5xx errors on listing.
#7
Updated by Ewoud Kohl van Wijngaarden over 2 years ago
Perhaps we can also use the #28384 to provide better debug instructions. I've asked @ https://github.com/theforeman/foreman/pull/7220#issuecomment-665141626 if it does.
#8
Updated by Ewoud Kohl van Wijngaarden over 2 years ago
- Triaged changed from No to Yes
- Target version deleted (
2.2.0) - Category set to Foreman modules
Removing the milestone since I don't think we'll get to this before 2.2.0 and it shouldn't block.
#9
Updated by The Foreman Bot about 2 years ago
- Assignee set to William Clark
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/puppet-foreman/pull/912 added
#10
Updated by The Foreman Bot about 2 years ago
- Fixed in Releases 2.4.0 added
#11
Updated by William Clark about 2 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset puppet-foreman|d0bfd990b3e84d096e621987b39542369394fe5e.
Fixes #30284 - Improve smartproxy registration failure error messages