Feature #3034
open
TFTP file download should be synchronous and handle errors
Added by Dominic Cleal over 11 years ago.
Updated almost 6 years ago.
Description
The TFTP file download feature currently spawns wget in the background, so offers no tracking of progress or download errors.
It should perform downloads as a synchronous operation, which will allow us to report success or failure back to Foreman when provisioning hosts. Async downloads also mean that Foreman often boots VMs up too quickly, before the boot files have downloaded.
wget has another issue under failure, as it leaves a zero byte file in place which means we think downloads were a success.
Given the proxy's usually deployed on WEBrick, a synchronous download could tie up its resources, making it inaccessible to others though.
- Related to Refactor #5121: Download kernel and image during OS creation rather than prior build added
- Bugzilla link set to https://bugzilla.redhat.com/show_bug.cgi?id=1110378
- Related to Bug #6289: vmlinuz/initrd files corrupted during when multiple hosts created simultaneously added
- Bugzilla link deleted (
https://bugzilla.redhat.com/show_bug.cgi?id=1110378)
For the record, RHOSP team hit this. We might want to speak about bumping up the priority of this.
- Bugzilla link set to 1215588
- Has duplicate Bug #11067: Failing TFTP fetch filed doesn't trigger error in UI added
- Has duplicate Bug #16609: race condition when using pxe icw virtual HW and a new OS added
- Status changed from New to Assigned
- Assignee set to Anonymous
- Related to Bug #16674: when downloading boot images, a failure does not fail the operation in the UI added
When touching this code, consider downloading the files under different (temporary) names so we shorten the window when different host (not the one being blocked by the download) sees incorrect file (e.g. during upgrading to newer version).
Also I would like to keep the current (asynchronous) behavior in some way so it can be used when we implement #5121
I am currently working on an issue when file was downloaded incorrectly (error during transmission) and wget is not able to fix this anymore since it only compares timestamps. If you can take this into consideration when designing the new way of downloading.
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/smart-proxy/pull/472 added
- Target version set to 1.3.2
- Related to Bug #5069: TFTP automatic boot file download does not track updates added
- Related to Feature #19389: Change TFTP filename pattern to include unique installation media ID added
- Bugzilla link changed from 1215588 to 1572592
- Pull request deleted (
https://github.com/theforeman/smart-proxy/pull/472)
- Target version deleted (
677)
- Status changed from Ready For Testing to New
- Triaged set to Yes
- Assignee deleted (
Anonymous)
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by Anonymous 
Updated by 
Updated by 
Updated by