Refactor #30512
SmartProxy#setting requires the object to be saved
Description
We are planning on using a smart proxy feature's setting to determine if a smart proxy is a 'mirror' or not in katello. This is complicated by the fact that the setting() method will not return correct results unless the object is fully saved.
Associated revisions
History
#1
Updated by The Foreman Bot over 2 years ago
Updated by - Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7864 added
#2
Updated by The Foreman Bot over 2 years ago
- Fixed in Releases 2.3.0 added
#3
Updated by Justin Sherrill over 2 years ago
Updated by - Status changed from Ready For Testing to Closed
Applied in changeset foreman|b414d567c8dd995b17e1f6be3c6c80bbc74b708c.
#4
Updated by The Foreman Bot over 2 years ago
- Pull request https://github.com/theforeman/foreman/pull/7975 added
Fixes #30512 - avoid query for smart proxy settings (#7864)
While this is less efficient, the number of
smart proxy features is low. This allows settings
to be read on an unsaved objects, improving testing
and allowing us to rely on settings in before_create.