Project

General

Profile

Refactor #30512

SmartProxy#setting requires the object to be saved

Added by Justin Sherrill about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Smart Proxy
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

We are planning on using a smart proxy feature's setting to determine if a smart proxy is a 'mirror' or not in katello. This is complicated by the fact that the setting() method will not return correct results unless the object is fully saved.

Associated revisions

Revision b414d567 (diff)
Added by Justin Sherrill about 1 year ago

Fixes #30512 - avoid query for smart proxy settings (#7864)

While this is less efficient, the number of
smart proxy features is low. This allows settings
to be read on an unsaved objects, improving testing
and allowing us to rely on settings in before_create.

History

#1 Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7864 added

#2 Updated by The Foreman Bot about 1 year ago

  • Fixed in Releases 2.3.0 added

#3 Updated by Justin Sherrill about 1 year ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/7975 added

Also available in: Atom PDF