Project

General

Profile

Bug #30667

dynflow-sidekiq results in messages logs getting filled up more frequently

Added by Adam Ruzicka 5 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Logging
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1865943

Description of problem:

dynflow-sidekiq results in messages logs getting filled up more frequently

Version-Release number of selected component (if applicable):

Red Hat Satellite 6.8 [snap 09]
tfm-rubygem-smart_proxy_dynflow-0.2.4-5.el7sat.noarch
tfm-rubygem-smart_proxy_dynflow_core-0.2.6-1.fm2_1.el7sat.noarch
tfm-rubygem-dynflow-1.4.6-1.el7sat.noarch
foreman-dynflow-sidekiq-2.1.0-1.el7sat.noarch

Dynflow sidekiq, logs inside /var/log/messages, and it is observed that for a single rex execution, there is additional logging compared to Red Hat Satellite v6.7

1. Assign few Ansible roles to the host
- RedHatInsights.insights-client
- theforeman.foreman_scap_client

2. Run Ansible Roles.

Actual Result

- For a host registered to Sat v.6.7, "/var/log/messages" was filled up with 4KB

- However for Sat v.6.8 "/var/log/messages" was filled up with 12kb.

This could impact users in a large environment where messages logs being frequently getting full.

Associated revisions

Revision 6b50650b (diff)
Added by Adam Ruzicka 5 months ago

Fixes #30667 - Reuse log level configured for Dynflow for Sidekiq

Sidekiq uses info log level by default, which is rather chatty but at the same
time doesn't really provide anything useful. This change makes Sidekiq "inherit"
the log level configured for Dynflow.

Revision 2ab92492 (diff)
Added by Adam Ruzicka 4 months ago

Refs #30667 - Use separate logger config for sidekiq workers

Sidekiq emits two log messages for each job it processes and those end up in
system journal and possibly /var/log/messages. Originally I opened a PR so
sidekiq workers would "inherit" their log levels from Dynflow loggers. This made
things configurable, but didn't really fix anything out of the box because
Dynflow's log level is set to INFO by default and that is the default level for
sidekiq as well. Since we need to change the log levels independently, new
logger dedicated to sidekiq is introduced.

History

#1 Updated by The Foreman Bot 5 months ago

  • Assignee set to Adam Ruzicka
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7912 added

#2 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases 2.3.0 added

#3 Updated by Adam Ruzicka 5 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7975 added

#5 Updated by Adam Ruzicka 5 months ago

  • Subject changed from dynflow-sidekiq results in messages logs getting filled up more frequently to dynflow-sidekiq results in messages logs getting filled up more frequently
  • Pull request deleted (https://github.com/theforeman/foreman/pull/7975)

#6 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8003 added

#7 Updated by Tomer Brisker 3 months ago

  • Category set to Logging

Also available in: Atom PDF