Project

General

Profile

Actions

Feature #30779

closed

Use ActionDispatch::RemoteIp when working as a reverse proxy

Added by Ewoud Kohl van Wijngaarden over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Settings
Target version:
-
Fixed in Releases:
Found in Releases:

Description

The ActionDispatch::RemoteIp middleware can provide the remote IP correctly as a property of the request object. It has an option to provide a list of trusted reverse proxies which needs to be exposed to the user. The installer should also expose this. It only needs to be in settings.yaml since middleware can't dynamically reload config.

This will replace the existing IpFromRequestEnv concern so it can be used application wide.

https://api.rubyonrails.org/classes/ActionDispatch/RemoteIp.html


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #32019: all requests are logged as coming from 127.0.0.1 in production.logDuplicateActions
Actions #1

Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/foreman/pull/7960 added
Actions #2

Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

  • Related to Bug #32019: all requests are logged as coming from 127.0.0.1 in production.log added
Actions #3

Updated by The Foreman Bot almost 4 years ago

  • Fixed in Releases 2.5.0 added
Actions #4

Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/8405 added
Actions #6

Updated by Amit Upadhye almost 4 years ago

  • Fixed in Releases 2.4.0 added
Actions #7

Updated by Tomer Brisker over 3 years ago

  • Fixed in Releases 2.3.4 added
  • Fixed in Releases deleted (2.5.0)
Actions

Also available in: Atom PDF