Bug #3081: Not setting ssl_ca, ssl_cert or ssl_key doesn't turn off the authentication in ENC - Installer - Foreman

Bug #3081

Not setting ssl_ca, ssl_cert or ssl_key doesn't turn off the authentication in ENC

Added by Ivan Necas over 9 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Foreman modules

Target version:

1.3.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

This patch should be enough to understand the issue

 if SETTINGS[:ssl_ca] && !SETTINGS[:ssl_ca].empty?
       http.ca_file = SETTINGS[:ssl_ca]
       http.verify_mode = OpenSSL::SSL::VERIFY_PEER
     else
       http.verify_mode = OpenSSL::SSL::VERIFY_NONE
     end
-    if SETTINGS[:ssl_cert] and SETTINGS[:ssl_key]
+    if SETTINGS[:ssl_cert] && !SETTINGS[:ssl_cert].empty? && SETTINGS[:ssl_key] && !SETTINGS[:ssl_key].empty?
       http.cert = OpenSSL::X509::Certificate.new(File.read(SETTINGS[:ssl_cert]))
       http.key  = OpenSSL::PKey::RSA.new(File.read(SETTINGS[:ssl_key]), nil)
     end