Project

General

Profile

Bug #30838

Do not return report contents (logs) after create

Added by Lukas Zapletal 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
Reporting
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Uploaded reports render themselves on upload via RABL and it looks like this is very slow. Generally, it's not needed to read the inserted data, so we should be able to completely remove this and return nothing. Alternatively, we could optimize this.


Related issues

Related to Foreman - Refactor #30820: Drop SHA1 digest and use hash index instead for reportsClosed
Related to Foreman - Refactor #30852: Optimize RABL rendering of uploaded reportsClosed

Associated revisions

Revision 4966f070 (diff)
Added by Lukas Zapletal 6 months ago

Fixes #30838 - do not return report after create

Uploaded reports render themselves on upload via RABL and it looks like this is very slow. Generally, it's not needed to read the inserted data, so we should be able to completely remove this and return nothing. Alternatively, we could optimize this.

Let's discuss how to solve this. Since report API is under heavy load, I
lean towards returning nothing, therefore deprecating the output
completely. The question is how to do this, deprecation warning message
is quite useless, so probably only Release Notes for 2.3?

History

#1 Updated by The Foreman Bot 7 months ago

  • Assignee set to Lukas Zapletal
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7987 added

#2 Updated by Lukas Zapletal 7 months ago

  • Related to Refactor #30820: Drop SHA1 digest and use hash index instead for reports added

#3 Updated by Lukas Zapletal 7 months ago

  • Subject changed from Optimize RABL rendering of uploaded reports to Do not return report contents (logs) after create

Renaming this issue to reflect the PR, creating a new one for refactoring.

#4 Updated by Lukas Zapletal 7 months ago

  • Related to Refactor #30852: Optimize RABL rendering of uploaded reports added

#5 Updated by The Foreman Bot 6 months ago

  • Fixed in Releases 2.3.0 added

#6 Updated by Lukas Zapletal 6 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF