Project

General

Profile

Feature #30856

Drop Puppet class initializer on startup

Added by Ewoud Kohl van Wijngaarden about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Puppet
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

On start up, the Puppet implementation updates all environments and retrieves the classes for each of them. This can be a fairly expensive operation. Warming up the caches is only relevant if caching on the Puppetserver is enabled (defaults to false) and if the environment doesn't change. For most deployments, this only adds overhead and doesn't actually improve performance.

Associated revisions

Revision 025c1f30 (diff)
Added by Ewoud Kohl van Wijngaarden about 1 year ago

Fixes #30856 - Drop Puppet class cache initializer

Retrieving all classes for all environments only makes sense if caching
is enabled on the Puppetserver. By default this is the case. Even if
this is not the case, it only works for environments that don't change.
It's sufficient to lazy load this.

This saves load on start up of services.

Revision 774fb1d9 (diff)
Added by Ewoud Kohl van Wijngaarden about 1 year ago

Refs #30856 - Fix class loading

025c1f3098f139ba5056cb2e97f3ceeefda68d78 removed this require, but that
file also contains the V3EnvironmentClassesApiClassesRetriever class
which is still used. This is a case of a bad rebase from my side.

History

#1 Updated by The Foreman Bot about 1 year ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/770 added

#2 Updated by The Foreman Bot about 1 year ago

  • Fixed in Releases 2.3.0 added

#3 Updated by Ewoud Kohl van Wijngaarden about 1 year ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/772 added

Also available in: Atom PDF