Project

General

Profile

Bug #30934

_invocation_form partial has hardcoded reference to report templates

Added by Adam Ruzicka 4 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Reporting
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

When used from a plugin, params end up under params["report_template_report"][...] instead of what the plugin might expect


Related issues

Related to Foreman Remote Execution - Bug #30935: type=search inputs end up under params["report_template_report"] in data sent to serverResolved
Related to Foreman Remote Execution - Bug #30933: undefined method `resource_type' for nil:NilClass when going to new job invocation form with template which has input of type searchClosed

Associated revisions

Revision c8908140 (diff)
Added by Ondřej Ezr 2 months ago

Fixes #30934 - improve template invocation_form inputs

Using `react_form_input` helper, that was introduced in 810504a13c
for rendering template invocation react inputs.

Hides all the input type implementations into a one helper method
to hide the implementation differences between React and Rails implemented inputs.

History

#1 Updated by Adam Ruzicka 4 months ago

  • Related to Bug #30935: type=search inputs end up under params["report_template_report"] in data sent to server added

#2 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8035 added

#3 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8060 added

#4 Updated by The Foreman Bot 2 months ago

  • Fixed in Releases 2.4.0 added

#5 Updated by Ondřej Ezr 2 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Tomer Brisker 2 months ago

  • Related to Bug #30933: undefined method `resource_type' for nil:NilClass when going to new job invocation form with template which has input of type search added

#7 Updated by Tomer Brisker 2 months ago

  • Bugzilla link set to 1899158

#8 Updated by Tomer Brisker 2 months ago

  • Fixed in Releases 2.3.0 added
  • Fixed in Releases deleted (2.4.0)

Also available in: Atom PDF