Bug #30936
Toast should support 'notice' type
Pull request:
Fixed in Releases:
Found in Releases:
Description
for example Foreman_remote_execution uses flash[:notice] which isn't shown as it's not supported in PF
helpers.js:38 Uncaught Error: Unsupported alert type=notice at getClassName (helpers.js:38) at Alert (Alert.js:27) at renderWithHooks (react-dom.development.js:15108) at mountIndeterminateComponent (react-dom.development.js:17342) at beginWork$1 (react-dom.development.js:18486) at HTMLUnknownElement.callCallback (react-dom.development.js:347) at Object.invokeGuardedCallbackDev (react-dom.development.js:397) at invokeGuardedCallback (react-dom.development.js:454) at beginWork$$1 (react-dom.development.js:23217) at performUnitOfWork (react-dom.development.js:22208) 14:15:39.103 react-dom.development.js:19814 The above error occurred in the <Alert> component: in Alert (created by ToastNotification) in ToastNotification (created by ToastsList) in div (created by ToastNotificationList) in ToastNotificationList (created by ToastsList) in ToastsList (created by ConnectFunction) in ConnectFunction (created by I18nProviderWrapper(Connect(ToastsList))) in IntlProvider (created by I18nProviderWrapper(Connect(ToastsList))) in I18nProviderWrapper(Connect(ToastsList)) (created by StoreProvider(I18nProviderWrapper(Connect(ToastsList)))) in Provider (created by StoreProvider(I18nProviderWrapper(Connect(ToastsList)))) in StoreProvider(I18nProviderWrapper(Connect(ToastsList)))
the ToastsList component should convert unknown types to info
Associated revisions
History
#1
Updated by Maria Agaphontzev 7 months ago
- Pull request https://github.com/theforeman/foreman/pull/7319 added
Fixed in this PR https://github.com/theforeman/foreman/pull/7319
#2
Updated by Maria Agaphontzev 7 months ago
- Description updated (diff)
#3
Updated by The Foreman Bot 7 months ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8036 added
#4
Updated by The Foreman Bot 6 months ago
- Fixed in Releases 2.3.0 added
#5
Updated by Maria Agaphontzev 6 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|f2f0b3d7189fecee7e9d49491a324e19bc13b53b.
Fixes #30936 - Toast should have fallback type