Bug #30936: Toast should support 'notice' type - Foreman

Actions

Copy link

Bug #30936

closed

Toast should support 'notice' type

Added by Maria Agaphontzev over 4 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Maria Agaphontzev

Category:

JavaScript stack

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/7319, https://github.com/theforeman/foreman/pull/8036

Fixed in Releases:

2.3.0

Found in Releases:

Red Hat JIRA:

Description

for example Foreman_remote_execution uses flash[:notice] which isn't shown as it's not supported in PF


helpers.js:38 Uncaught Error: Unsupported alert type=notice
    at getClassName (helpers.js:38)
    at Alert (Alert.js:27)
    at renderWithHooks (react-dom.development.js:15108)
    at mountIndeterminateComponent (react-dom.development.js:17342)
    at beginWork$1 (react-dom.development.js:18486)
    at HTMLUnknownElement.callCallback (react-dom.development.js:347)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:397)
    at invokeGuardedCallback (react-dom.development.js:454)
    at beginWork$$1 (react-dom.development.js:23217)
    at performUnitOfWork (react-dom.development.js:22208)
14:15:39.103 react-dom.development.js:19814 The above error occurred in the <Alert> component:
    in Alert (created by ToastNotification)
    in ToastNotification (created by ToastsList)
    in div (created by ToastNotificationList)
    in ToastNotificationList (created by ToastsList)
    in ToastsList (created by ConnectFunction)
    in ConnectFunction (created by I18nProviderWrapper(Connect(ToastsList)))
    in IntlProvider (created by I18nProviderWrapper(Connect(ToastsList)))
    in I18nProviderWrapper(Connect(ToastsList)) (created by StoreProvider(I18nProviderWrapper(Connect(ToastsList))))
    in Provider (created by StoreProvider(I18nProviderWrapper(Connect(ToastsList))))
    in StoreProvider(I18nProviderWrapper(Connect(ToastsList)))

the ToastsList component should convert unknown types to info