Project

General

Profile

Actions

Bug #30939

closed

Katello 4.0.0 deprecations

Added by James Jeffers over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Fixed in Releases:
Found in Releases:

Description

The following are indicated deprecations for the 4.0.0 release:

Scanning for deprecation warnings in /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/**/*.rb, /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/lib/**/*.rb

Deprecation warnings were found with versions that are outdated, please check below and ensure both the deprecated functionality and the deprecation warning are removed if the deprecation is outdated in this release

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb line 70 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/controllers/katello/api/v2/gpg_keys_controller.rb line 111 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/controllers/katello/api/v2/api_controller.rb line 42 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/controllers/katello/api/v2/repositories_controller.rb line 226 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/lib/actions/katello/repository/update.rb line 17 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/lib/actions/katello/repository/update.rb line 21 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/lib/actions/katello/repository/create.rb line 14 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/lib/actions/katello/repository/create.rb line 18 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

No deprecation warnings found that will be outdated in the next version!

Puppet and OStree content types are at:
app/lib/actions/katello/repository/create.rb line 18
app/lib/actions/katello/repository/update.rb line 21
app/controllers/katello/api/v2/repositories_controller.rb line 226

GPG controller deprecation:
api/v2/gpg_keys_controller.rb

CandeplinDynflow controller deprecation:
api/rhsm/candlepin_dynflow_proxy_controller.rb

Background download policy deprecation:
app/lib/actions/katello/repository/create.rb
epos/katello/4.0.0/katello/app/lib/actions/katello/repository/update.rb line 17


Related issues 1 (0 open1 closed)

Has duplicate Katello - Refactor #32260: Remove all puppet-related commands from hammer-cli-katelloDuplicateJames JeffersActions
Actions #1

Updated by John Mitsch over 3 years ago

  • Category set to API
  • Triaged changed from No to Yes
Actions #2

Updated by Jonathon Turel over 3 years ago

We should also check for any APIs or API params which are marked as deprecated - I don't think the tool picks those up. Quick grep turned these up and cleaning them up with 4.0 is probably good!

app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb:    before_action :deprecated, only: :deb_package_profile
app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb:    def deprecated
app/controllers/katello/api/v2/api_controller.rb:      ::Foreman::Deprecation.api_deprecation_warning("Remote actions using katello-agent are deprecated and will be removed in Katello 4.0.  
app/controllers/katello/api/v2/content_view_puppet_modules_controller.rb:    param :uuid, String, :desc => N_("uuid of the puppet module"), :deprecated => true
app/controllers/katello/api/v2/content_view_puppet_modules_controller.rb:    param :uuid, String, :desc => N_("the uuid of the puppet module to associate"), :deprecated => true
app/controllers/katello/api/v2/content_view_puppet_modules_controller.rb:    param :uuid, String, :desc => N_("the uuid of the puppet module to associate"), :deprecated => true
app/controllers/katello/api/v2/content_view_versions_controller.rb:        ::Foreman::Deprecation.api_deprecation_warning("Export is being deprecated and will be removed in a future version 
app/controllers/katello/api/v2/errata_controller.rb:    api :GET, "/content_view_versions/:id/available_errata", N_("Return errata that can be added to the Content View Version via an Increm
app/controllers/katello/api/v2/gpg_keys_controller.rb:    before_action :deprecated
app/controllers/katello/api/v2/gpg_keys_controller.rb:    def deprecated
app/controllers/katello/api/v2/host_errata_controller.rb:    param :errata_ids, Array, :desc => N_("List of Errata ids to install"), :required => false, :deprecated => true
app/controllers/katello/api/v2/organizations_controller.rb:        param :config_template_ids, Array, N_("Provisioning template IDs"), :required => false # FIXME: deprecated
app/controllers/katello/api/v2/repositories_controller.rb:      param :download_policy, ["immediate", "on_demand", "background"], :desc => N_("download policy for yum repos (either 'immediat
app/controllers/katello/api/v2/repositories_controller.rb:      param :ignore_global_proxy, :bool, :desc => N_("if true, will ignore the globally configured proxy when syncing"), :deprecated
Actions #3

Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to James Jeffers
  • Pull request https://github.com/Katello/katello/pull/9123 added
Actions #4

Updated by James Jeffers about 3 years ago

Updated deprecations:

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/controllers/katello/api/rhsm/candlepin_dynflow_proxy_controller.rb line 70 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/controllers/katello/api/v2/gpg_keys_controller.rb line 111 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/controllers/katello/api/v2/repositories_controller.rb line 231 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/lib/actions/katello/repository/update.rb line 18 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/lib/actions/katello/repository/update.rb line 22 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/lib/actions/katello/repository/create.rb line 14 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Deprecation warning at /home/jjeffers/projects/tool_belt/repos/katello/4.0.0/katello/app/lib/actions/katello/repository/create.rb line 18 is marked for removal in version 4.0, which is less than or equal to the specified version of 4.0.0.

Actions #5

Updated by James Jeffers about 3 years ago

  • Pull request deleted (https://github.com/Katello/katello/pull/9123)
Actions #6

Updated by The Foreman Bot about 3 years ago

  • Pull request https://github.com/Katello/katello/pull/9127 added
Actions #7

Updated by The Foreman Bot about 3 years ago

  • Pull request https://github.com/Katello/hammer-cli-katello/pull/780 added
Actions #8

Updated by The Foreman Bot about 3 years ago

  • Fixed in Releases Katello 4.1.0 added
Actions #9

Updated by James Jeffers about 3 years ago

  • Status changed from Ready For Testing to Closed
Actions #10

Updated by Chris Roberts about 3 years ago

  • Pull request deleted (https://github.com/Katello/hammer-cli-katello/pull/780)
Actions #11

Updated by The Foreman Bot about 3 years ago

  • Pull request https://github.com/Katello/hammer-cli-katello/pull/782 added
Actions #12

Updated by Jonathon Turel about 3 years ago

  • Has duplicate Refactor #32260: Remove all puppet-related commands from hammer-cli-katello added
Actions

Also available in: Atom PDF