Project

General

Profile

Refactor #30942

Refactor #30544: Deprecate the mount_react_component method

replace mount_react_component with react_component in mount_breadcrumbs

Added by Ondřej Ezr 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Refactor #30604: replace mount_react_component with react_component in app/helpers/layout_helper.rbClosed
Related to Foreman - Bug #31111: Unset welcome flag, if the controller doesn't have welcome templateClosed

Associated revisions

Revision e59d625e (diff)
Added by Ondřej Ezr 6 months ago

Fixes #30942 - use react_component to mount breadcrumbs

Replaces the deprecated mount_react_component with react_component.
Removes the title, that was replaced by react-dom by the old mechanism, but
now it would duplicate the page title.

Move integration tests, that test breadcrumbs to tests with JS support.
We have been testing dead (invisible with React) elements, so that make no sense.

History

#1 Updated by Ondřej Ezr 7 months ago

  • Related to Refactor #30604: replace mount_react_component with react_component in app/helpers/layout_helper.rb added

#2 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8040 added

#3 Updated by Ondřej Ezr 6 months ago

  • Related to Bug #31111: Unset welcome flag, if the controller doesn't have welcome template added

#4 Updated by The Foreman Bot 6 months ago

  • Fixed in Releases 2.3.0 added

#5 Updated by Ondřej Ezr 6 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF