Project

General

Profile

Bug #30997

Operatingsystem icon returns always img_tag if OS familiy icon is missing

Added by Ondřej Ezr 12 months ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
Rails
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8045
Fixed in Releases:
2.3.0
Found in Releases:

Description

In one edge case (No OS family) we don't return image_path or img_tag depending on caller, but always img_tag.

in `app/helpers/operatingsystems_helper.rb`

Associated revisions

Revision 70dab3f7 (diff)
Added by Ondřej Ezr 12 months ago

Fixes #30997 - allow image_path in all cases

Fix return value in blank icon edge case.

History

#1 Updated by The Foreman Bot 12 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8045 added

#2 Updated by The Foreman Bot 12 months ago

  • Fixed in Releases 2.3.0 added

#3 Updated by Ondřej Ezr 12 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF