Project

General

Profile

Bug #31111

Unset welcome flag, if the controller doesn't have welcome template

Added by Ondřej Ezr 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
-
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Refactor #30942: replace mount_react_component with react_component in mount_breadcrumbsClosed

Associated revisions

Revision 7a489977 (diff)
Added by Ondřej Ezr 5 months ago

Fixes #31111 - set welcome flag only if welcome exists

Set @welcome, only if the 'welcome' template exists for given resource.
It messes up some other parts of layout, if the flag is wrongly set.

To support this, it also improves the rescue and moves it to `safe_constantize` failsafe in `model_of_controller` method.

History

#1 Updated by Ondřej Ezr 6 months ago

  • Related to Refactor #30942: replace mount_react_component with react_component in mount_breadcrumbs added

#2 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8088 added

#3 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases 2.4.0 added

#4 Updated by Ondřej Ezr 5 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF