Project

General

Profile

Refactor #31143

Use single quotes in registration templates for curl

Added by Marek Hulán about 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Host registration
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Feature #30440: Simple & automatic host registration WFClosed

Associated revisions

Revision 1a144f1f (diff)
Added by Marek Hulán 11 months ago

Fixes #31143 - use single quotes in registration templates

This is generally safer to avoid shell injection through macros. Also
URLs can contain & in between parameters, which also causes shell side
effects. This replaces all " with ' where it makes sense.

History

#1 Updated by Marek Hulán about 1 year ago

  • Related to Feature #30440: Simple & automatic host registration WF added

#2 Updated by Marek Hulán about 1 year ago

  • Subject changed from Use signle quotes and refactor the big context hash in the registration controller to Use single quotes in registration templates for curl

#3 Updated by The Foreman Bot about 1 year ago

  • Assignee set to Marek Hulán
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8098 added

#4 Updated by The Foreman Bot 11 months ago

  • Fixed in Releases 2.4.0 added

#5 Updated by Marek Hulán 11 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Tomer Brisker 7 months ago

  • Category set to Host registration

Also available in: Atom PDF