Project

General

Profile

Actions

Feature #31301

closed

Arbitrary headers with ERB rendering

Added by Lukas Zapletal over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

For better Shellhooks plugin integration, we should allow passing arguments into scripts via X-Shellhook-Arg-N named HTTP headers. To allow that, we need to extend webhook with headers, the reasonable solution is to have one string/text SQL column with headers stored in JSON, which can be nicely presented to the user in the UI and CLI.

ERB will be enabled in the headers themselves as well as in URL for easier integration with backend services directly. This patch only prepares the field for #31299 if we choose to implement it.


Related issues 1 (1 open0 closed)

Related to Foreman - Tracker #30290: Foreman webhooks integration storyNewLukas Zapletal

Actions
Actions #1

Updated by Lukas Zapletal over 3 years ago

Actions #2

Updated by Lukas Zapletal over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_webhooks/pull/15 added
Actions #3

Updated by Anonymous over 3 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF