Bug #31317
closedVNC Console broken
Description
Hi,
the VNC connection in 2.2.0 was broken because it was using "ws://" instead of "wss://" in my case (:websockets_encrypt: on).
It only showed "Disconnected." in the console tab. Nothing else/more.
Turning debug logging on only resulted in nonsense "error" messages:
2020-11-16T10:14:15 [D|app|46df8879] VNCProxy Error: WebSocket server settings:
46df8879 |
2020-11-16T10:14:15 [D|app|46df8879] VNCProxy Error: - Listen on :5929
46df8879 |
2020-11-16T10:14:15 [D|app|46df8879] VNCProxy Error: - Flash security policy server
46df8879 |
2020-11-16T10:14:15 [D|app|46df8879] VNCProxy Error: - SSL/TLS support
46df8879 |
2020-11-16T10:14:15 [D|app|46df8879] VNCProxy Error: - Backgrounding (daemon)
46df8879 |
So those errors, which weren't actual errors, didn't help.
This was likely introduced via #27319, especially https://github.com/theforeman/foreman/pull/6907/files#diff-acf85befb293c237348f2c37f605909896cb7240beca4c7d7ad7a62d5fe8ead5R20
tbrisker provided a possible fix via IRC:
idl0r: can you try changing https://github.com/theforeman/foreman/pull/6907/files#diff-acf85befb293c237348f2c37f605909896cb7240beca4c7d7ad7a62d5fe8ead5R20 to data-encrypt='<%= @encrypt %>' ?
Which we did and it worked afterwards.
Previously the JS error console of the browser logged "Failed when connecting: Error when opening socket (SecurityError: The operation is insecure.)"
Updated by Tomer Brisker almost 4 years ago
- Related to Feature #27319: VNC console for kubevirt added
Updated by Tomer Brisker almost 4 years ago
- Category set to VM management
- Target version set to 2.2.2
Updated by The Foreman Bot almost 4 years ago
- Status changed from New to Ready For Testing
- Assignee set to Shira Maximov
- Pull request https://github.com/theforeman/foreman/pull/8138 added
Updated by Tomer Brisker almost 4 years ago
- Fixed in Releases 2.2.2, 2.3.0 added
- Fixed in Releases deleted (
2.4.0)
Updated by Tomer Brisker almost 4 years ago
- Subject changed from VNC Console broken through #27319 to VNC Console broken
Updated by Shira Maximov almost 4 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|c11b75613e75a1093d5e6ebcb87a29643d90e457.