Bug #31348
Intermediate script is broken due to URL encoded parameters
Difficulty:
easy
Triaged:
Yes
Pull request:
Description
We made a change to cleanup iPXE template code by using <%= foreman_url('iPXE', mac: "${net#{i}/mac}") %>
which is cleaner but it has one major issue, it renders to URL encoded string: http://foreman.some.host.fqdn/unattended/iPXE?mac=%24%7Bnet0%2Fmac%7D
while this should be http://foreman.some.host.fqdn/unattended/iPXE?mac=${net0/mac}
This breaks iPXE workflow completely.
Associated revisions
History
#1
Updated by Lukas Zapletal over 2 years ago
- Triaged changed from No to Yes
- Target version set to 2.3.0
Requesting 2.3, this is a regression we introduced which completely breaks iPXE provisioning without tokens.
#2
Updated by The Foreman Bot over 2 years ago
- Assignee set to Lukas Zapletal
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8143 added
#3
Updated by The Foreman Bot over 2 years ago
- Fixed in Releases 2.4.0 added
#4
Updated by Tomer Brisker over 2 years ago
- Fixed in Releases 2.3.0 added
- Fixed in Releases deleted (
2.4.0)
#5
Updated by Lukas Zapletal over 2 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|174c73545fcc4a5d44a695c6904f65c9070cf8f1.
#6
Updated by Tomer Brisker over 2 years ago
- Category set to Templates
Fixes #31348 - raw params in foreman_url support