Project

General

Custom queries

Profile

Actions
Copy link

Bug #31348

closed

Intermediate script is broken due to URL encoded parameters

Added by Lukas Zapletal over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
High
Assignee:
Lukas Zapletal
Category:
Templates
Target version:
2.3.0
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8143
Fixed in Releases:
2.3.0
Found in Releases:
Red Hat JIRA:

Description

We made a change to cleanup iPXE template code by using <%= foreman_url('iPXE', mac: "${net#{i}/mac}") %> which is cleaner but it has one major issue, it renders to URL encoded string: http://foreman.some.host.fqdn/unattended/iPXE?mac=%24%7Bnet0%2Fmac%7D while this should be http://foreman.some.host.fqdn/unattended/iPXE?mac=${net0/mac}

This breaks iPXE workflow completely.

Actions
Copy link
 #1

Updated by Lukas Zapletal over 4 years ago

  • Target version set to 2.3.0
  • Triaged changed from No to Yes

Requesting 2.3, this is a regression we introduced which completely breaks iPXE provisioning without tokens.

Actions
Copy link
 #2

Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/8143 added
Actions
Copy link
 #3

Updated by The Foreman Bot over 4 years ago

  • Fixed in Releases 2.4.0 added
Actions
Copy link
 #4

Updated by Tomer Brisker over 4 years ago

  • Fixed in Releases 2.3.0 added
  • Fixed in Releases deleted (2.4.0)
Actions
Copy link
 #5

Updated by Lukas Zapletal over 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #6

Updated by Tomer Brisker over 4 years ago

  • Category set to Templates
Actions
Copy link

Also available in: Atom PDF