Project

General

Profile

Bug #31368

Simplify mount_search_bar method

Added by Tomer Brisker 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Search
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

This method is only used by the main layout and has many parameters that are always set to the default value or not even used. It can be simplified.

Associated revisions

Revision 2a0e0ce6 (diff)
Added by Tomer Brisker 8 months ago

Fixes #31368 - Simplify mount_search_bar method

This method made a lot of preperations for customization, but in
practice it is never used except for the default case in the main
layout. Any more elaborate customization should be done in react and
not in erb.

History

#1 Updated by The Foreman Bot 8 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8148 added

#2 Updated by The Foreman Bot 8 months ago

  • Fixed in Releases 2.4.0 added

#3 Updated by Tomer Brisker 8 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF