Project

General

Profile

Feature #31408

Improve selecting of related network to subnet VLAN ID

Added by Ondřej Ezr about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Network
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

related network is slected by fulltext search of a VLAN ID in the network name, we should first try to find the exact numeric match prior to the fulltext search.
Now we for VLAN_ID=5 we select network55 if it's in the list first even if there is VLAN-5 later in the list.


Related issues

Related to Foreman - Feature #21676: Select related vmware network when selecting a subnetClosed2017-11-15

Associated revisions

Revision 42a74040 (diff)
Added by Simon Peeters about 2 months ago

Fixes #31408 - Use regexp to match networks by VLAN ID

Given that vlan ids are numbers there's a big difference between vlan 23 and vlan 123
With just the substring match foreman would easily confuse the 2.
This introduce a regexp matching for the VLANID and fullstring match only as a fallback.

History

#1 Updated by Ondřej Ezr about 2 months ago

  • Related to Feature #21676: Select related vmware network when selecting a subnet added

#2 Updated by The Foreman Bot about 2 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7901 added

#3 Updated by The Foreman Bot about 2 months ago

  • Fixed in Releases 2.4.0 added

#4 Updated by Anonymous about 2 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Tomer Brisker about 2 months ago

  • Category changed from Compute resources to Network
  • Fixed in Releases 2.3.0 added
  • Fixed in Releases deleted (2.4.0)

Also available in: Atom PDF