Project

General

Profile

Bug #3141

undefined local variable or method `render_403' for #<Api::V2::ReportsController:0x007fcbd80ed5c0>

Added by Dominic Cleal about 9 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
-
Category:
API
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The "render_403" method isn't available from the API controller, only the UI controller. Now the smart proxy auth is called from the API reports controller, when smart proxy auth fails it calls this method and hits this error:

Started POST "/api/reports" for 127.0.0.1 at 2013-09-24 10:22:45 +0200
Processing by Api::V2::ReportsController#create as JSON
  Parameters: {"report"=>"[FILTERED]"}
Verifying request from ["localhost", "localhost.localdomain", "localhost4", "localhost4.localdomain4"] against []
No smart proxy server found on ["localhost", "localhost.localdomain", "localhost4", "localhost4.localdomain4"] and is not in trusted_puppetmaster_hosts
undefined local variable or method `render_403' for #<Api::V2::ReportsController:0x007fcbd80ed5c0> (NameError)
/home/dcleal/code/foreman/foreman/app/controllers/concerns/foreman/controller/smart_proxy_auth.rb:28:in `require_puppetmaster_or_login'

(regression)

Associated revisions

Revision dd1d641e (diff)
Added by Dmitri Dolguikh about 9 years ago

fixes #3141: SmartPrpxyAuth no longer calls #render_403 method defined in ApplicationController

Revision a836f881 (diff)
Added by Dmitri Dolguikh about 9 years ago

refs #3141 - added tests around Foreman::Controller::SmartProxyAuth

Revision 8ffce956 (diff)
Added by Dmitri Dolguikh about 9 years ago

fixes #3141: SmartPrpxyAuth no longer calls #render_403 method defined in ApplicationController

(cherry picked from commit dd1d641eaa6cc358d80e1372b2ada0382996aadf)

Revision 9a773377 (diff)
Added by Dmitri Dolguikh about 9 years ago

refs #3141 - added tests around Foreman::Controller::SmartProxyAuth

(cherry picked from commit a836f8819fe7bc6af95fa82e657a22e1e1a37b9a)

History

#1 Updated by Anonymous about 9 years ago

  • Assignee set to Anonymous
  • Status changed from New to Assigned

#2 Updated by Anonymous about 9 years ago

  • Status changed from Assigned to Ready For Testing

#3 Updated by Anonymous about 9 years ago

  • Status changed from Ready For Testing to Closed

fixed in dd1d641eaa6cc358d80e1372b2ada0382996aadf

#4 Updated by Dominic Cleal about 9 years ago

  • Related to Tracker #3112: [TRACKER] Issues to be released in 1.3 RC or final added

#5 Updated by Dominic Cleal about 9 years ago

lzap, please note there are two associated commits (dd1d641e and a836f881) for this issue.

#6 Updated by Lukas Zapletal about 9 years ago

  • Related to deleted (Tracker #3112: [TRACKER] Issues to be released in 1.3 RC or final)

Also available in: Atom PDF