Bug #31424: remove 'load' from rake tasks - Katello - Foreman

Actions

Copy link

Bug #31424

closed

remove 'load' from rake tasks

Added by Justin Sherrill over 4 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Justin Sherrill

Category:

Tooling

Target version:

Katello 3.18.2

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/9100

Fixed in Releases:

Katello 4.1.0

Found in Releases:

Red Hat JIRA:

Description

we currently call load within a few rake tasks:

lib/katello/tasks/delete_orphaned_content.rake:load "#{Katello::Engine.root}/lib/katello/tasks/common.rake"
lib/katello/tasks/pulp3_migration.rake:load "#{Katello::Engine.root}/lib/katello/tasks/common.rake"
lib/katello/tasks/pulp3_post_migration_check.rake:load "#{Katello::Engine.root}/lib/katello/tasks/common.rake"
lib/katello/tasks/repository.rake:load "#{Katello::Engine.root}/lib/katello/tasks/common.rake"

This can cause tasks to be double loaded and double executed. We likely could load common.rake first here: https://github.com/Katello/katello/blob/master/lib/katello/engine.rb#L242-L247