Project

General

Profile

Actions

Bug #31424

closed

remove 'load' from rake tasks

Added by Justin Sherrill over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Tooling
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

we currently call load within a few rake tasks:

lib/katello/tasks/delete_orphaned_content.rake:load "#{Katello::Engine.root}/lib/katello/tasks/common.rake"
lib/katello/tasks/pulp3_migration.rake:load "#{Katello::Engine.root}/lib/katello/tasks/common.rake"
lib/katello/tasks/pulp3_post_migration_check.rake:load "#{Katello::Engine.root}/lib/katello/tasks/common.rake"
lib/katello/tasks/repository.rake:load "#{Katello::Engine.root}/lib/katello/tasks/common.rake"

This can cause tasks to be double loaded and double executed. We likely could load common.rake first here: https://github.com/Katello/katello/blob/master/lib/katello/engine.rb#L242-L247

Actions #1

Updated by Jonathon Turel over 3 years ago

  • Target version set to Katello 3.17.2
  • Triaged changed from No to Yes
Actions #2

Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Justin Sherrill
  • Pull request https://github.com/Katello/katello/pull/9100 added
Actions #3

Updated by Chris Roberts about 3 years ago

  • Target version changed from Katello 3.17.2 to Katello 3.18.2
Actions #4

Updated by The Foreman Bot about 3 years ago

  • Fixed in Releases Katello 4.1.0 added
Actions #5

Updated by Justin Sherrill about 3 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF