Project

General

Profile

Bug #31517

Remove usage of deprecated Net::LDAP::LdapError

Added by Ondřej Ezr 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
Users, Roles and Permissions
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8205
Fixed in Releases:
2.4.0
Found in Releases:

Description

In https://github.com/ruby-ldap/ruby-net-ldap/commit/94b9d4d0443b8be37b91fcb5d6a31a9589cca41a#diff-8e534ef69e7fb9fbb691ec029ba3883243f8ffec6c89f9fadfa13a73d5b737fb error has got removed, so it will not be around once we upgrade to new version of net-ldap (>= 0.17.0).

We should get rid of usage to avoid UninitializedConstant Errors.

Associated revisions

Revision 0070c1d9 (diff)
Added by Ondřej Ezr about 2 months ago

Fixes #31517 - do not use deprecated Net::LDAP:LdapError

`Net::LDAP::LdapError` has been deprecated in favor of `Net::LDAP::Error` since https://github.com/ruby-ldap/ruby-net-ldap/commit/c9d36cdf919e01996da5c61838c10c1bc59f3e81#diff-8e534ef69e7fb9fbb691ec029ba3883243f8ffec6c89f9fadfa13a73d5b737fb.
In https://github.com/ruby-ldap/ruby-net-ldap/commit/94b9d4d0443b8be37b91fcb5d6a31a9589cca41a#diff-8e534ef69e7fb9fbb691ec029ba3883243f8ffec6c89f9fadfa13a73d5b737fb it has got removed, so it will not be around once we upgrade to new version of `net-ldap`.
This should prevent UninitializedConstant Errors.

History

#1 Updated by Ondřej Ezr 3 months ago

  • Subject changed from Remove usage of Deprecated Net::LDAP::LdapError to Remove usage of deprecated Net::LDAP::LdapError

#2 Updated by The Foreman Bot 3 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8205 added

#3 Updated by The Foreman Bot about 2 months ago

  • Fixed in Releases 2.4.0 added

#4 Updated by Ondřej Ezr about 2 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF