Project

General

Profile

Bug #31561

fix propTypes in EmptyStatePattern

Added by Maria Agaphontzev 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Maria Agaphontzev
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8224
Fixed in Releases:
2.3.2, 2.4.0
Found in Releases:

Description

Tests are failing because:

'documentation.label' is missing in props validation
test (14): webpack/assets/javascripts/react_app/components/common/EmptyState/EmptyStatePattern.js#L34
'documentation.buttonLabel' is missing in props validation
test (14): webpack/assets/javascripts/react_app/components/common/EmptyState/EmptyStatePattern.js#L35
'documentation.url' is missing in props validation

Associated revisions

Revision 0bbc2b9b (diff)
Added by Maria Agaphontzev 5 months ago

Fixes #31561 - fix propTypes in EmptyStatePattern

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8224 added

#2 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases 2.4.0 added

#3 Updated by Tomer Brisker 5 months ago

  • Fixed in Releases 2.3.2 added

#4 Updated by Maria Agaphontzev 5 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF