Project

General

Profile

Bug #31730

Cleanup hook names in event_name_for

Added by Lukas Zapletal about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Plugin integration
Target version:
2.4.0
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8319, https://github.com/theforeman/foreman/pull/8284
Fixed in Releases:
2.4.0
Found in Releases:
Red Hat JIRA:

Description

Events created from Ruby namespace often contain slash characters which looks weird: actions/remote_execution/run_hosts_job_stopped.event.foreman.event.foreman

Let's convert them to dots.

Related issues

Related to Foreman - Tracker #30290: Foreman webhooks integration storyNew

Related to Foreman - Feature #31647: Ability to add new arbitrary event via plugin APIResolved

Associated revisions

Revision eb60c400 (diff)
Added by Lukas Zapletal about 2 years ago

Fixes #31730 - cleaner event name and documentation

History

#1 Updated by Lukas Zapletal about 2 years ago

#2 Updated by Lukas Zapletal about 2 years ago

  • Project changed from Webhooks to Foreman

#3 Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8284 added

#4 Updated by The Foreman Bot about 2 years ago

  • Fixed in Releases 2.5.0 added

#5 Updated by Lukas Zapletal about 2 years ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Lukas Zapletal about 2 years ago

  • Target version set to 2.4.0

Requesting 2.4 so we can release plugins for this versions with events support.

#7 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/8319 added

#8 Updated by Lukas Zapletal about 2 years ago

  • Related to Feature #31647: Ability to add new arbitrary event via plugin API added

#9 Updated by Tomer Brisker about 2 years ago

  • Fixed in Releases 2.4.0 added
  • Fixed in Releases deleted (2.5.0)

#10 Updated by Tomer Brisker about 2 years ago

  • Category set to Plugin integration

Also available in: Atom PDF