Project

General

Profile

Actions
Copy link

Bug #31758

closed

Unterminated single quote in chainloader pxeboot template breaks grub2 parser

Added by Scott Lindeneau almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Templates
Target version:
2.3.3
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8299, https://github.com/theforeman/foreman/pull/8316, https://github.com/theforeman/foreman/pull/8317
Fixed in Releases:
2.3.3, 2.4.0
Found in Releases:
Red Hat JIRA:

Description

In develop, grub2 parser cannot parse the single quote introduced in this commit:

https://github.com/theforeman/foreman/commit/694b95f206e344d805f9ca9f5543f6a383ed2c7a#diff-a66d2f0432f9af6d5777b076a71dadbb498843748eef3e3b67577cb39fa12c1b

Pull request with fix here:

https://github.com/theforeman/foreman/pull/8299

Actions
Copy link
 #1

Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
Actions
Copy link
 #2

Updated by Lukas Zapletal almost 4 years ago

  • Category set to Templates
  • Assignee set to Lukas Zapletal
  • Target version set to 2.3.3
  • Triaged changed from No to Yes

We need to fix this in 2.3 and 2.4, tiny change.

Actions
Copy link
 #3

Updated by The Foreman Bot almost 4 years ago

  • Fixed in Releases 2.5.0 added
Actions
Copy link
 #4

Updated by Scott Lindeneau almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #5

Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/8316 added
Actions
Copy link
 #6

Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/8317 added
Actions
Copy link
 #7

Updated by Tomer Brisker almost 4 years ago

  • Fixed in Releases 2.3.3, 2.4.0 added
  • Fixed in Releases deleted (2.5.0)
Actions
Copy link

Also available in: Atom PDF