Project

General

Profile

Bug #31758

Unterminated single quote in chainloader pxeboot template breaks grub2 parser

Added by Scott Lindeneau 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Templates
Target version:
2.3.3
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8299, https://github.com/theforeman/foreman/pull/8317, https://github.com/theforeman/foreman/pull/8316
Fixed in Releases:
2.3.3, 2.4.0
Found in Releases:

Description

In develop, grub2 parser cannot parse the single quote introduced in this commit:

https://github.com/theforeman/foreman/commit/694b95f206e344d805f9ca9f5543f6a383ed2c7a#diff-a66d2f0432f9af6d5777b076a71dadbb498843748eef3e3b67577cb39fa12c1b

Pull request with fix here:

https://github.com/theforeman/foreman/pull/8299

Associated revisions

Revision f36cf952 (diff)
Added by Scott Lindeneau 6 months ago

Fixes #31758 - Unterminated single quote in chainloader pxeboot template breaks grub2 parser

Changes wording from can't to cannot to remove unterminated single quote.

History

#1 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing

#2 Updated by Lukas Zapletal 6 months ago

  • Triaged changed from No to Yes
  • Target version set to 2.3.3
  • Assignee set to Lukas Zapletal
  • Category set to Templates

We need to fix this in 2.3 and 2.4, tiny change.

#3 Updated by The Foreman Bot 6 months ago

  • Fixed in Releases 2.5.0 added

#4 Updated by Scott Lindeneau 6 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8316 added

#6 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8317 added

#7 Updated by Tomer Brisker 5 months ago

  • Fixed in Releases 2.3.3, 2.4.0 added
  • Fixed in Releases deleted (2.5.0)

Also available in: Atom PDF