Project

General

Profile

Actions

Feature #3182

closed

Remove requirement for entering an IP address when creating a new host

Added by Dominic Cleal over 10 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Host creation
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

In some scenarios, it's valid for a host's IP address to be optional and so the new host form shouldn't require it.

This would mean you then can't use DNS or DHCP orchestration, static IP-based foreman_bootdisk, etc. Perhaps if the user has DNS or DHCP orchestration configured, it should be mandatory.


Related issues 3 (0 open3 closed)

Related to Foreman - Feature #2576: Optionally update Host.ip as part of /unattended/builtClosedGreg Sutcliffe05/28/2013Actions
Related to Foreman - Feature #359: Add support for 'hostname=<hostname>' spoofing for Unattended InstallsClosedDaniel Lobato Garcia07/27/2010Actions
Has duplicate Foreman - Feature #2214: Specifying host IP address should not be mandatory for unmanaged DNS/DHCP subnetsDuplicate02/17/2013Actions
Actions #1

Updated by Dominic Cleal over 10 years ago

  • Related to Feature #2576: Optionally update Host.ip as part of /unattended/built added
Actions #2

Updated by Greg Sutcliffe over 10 years ago

  • Status changed from New to Assigned
  • Target version set to 1.4.0

This is fairly straightforward I think. We already have Host#require_ip_validation as a method, this can have logic added to cover:

  • IP needed if the Host is assigned to a DNS and/or DHCP proxy (since the IP is needed for those functions)
  • IP not needed if the above is not true and tokens are enabled (otherwise IP is needed for templates)
  • IP not needed if it's an image based deployment (since there's only a finish template, and Foreman sends it, it's not retrieved by the host)

Sound good?

Actions #3

Updated by Dominic Cleal over 10 years ago

Sounds good. A few more thoughts:

- check for areas of the UI that might assume the IP is always stored too, see they display OK?
- add a test fixture without an IP
- ensure the API works consistently

Actions #4

Updated by Greg Sutcliffe over 10 years ago

Tests are a given ofc. I'll see what I can do about the UI. What are you thinking of re: the API?

Actions #5

Updated by Dominic Cleal over 10 years ago

That the API doc didn't require it - just checked and it doesn't, so nvm.

Actions #6

Updated by Greg Sutcliffe over 10 years ago

  • Target version deleted (1.4.0)
Actions #7

Updated by Greg Sutcliffe over 10 years ago

  • Target version set to 1.15.0
Actions #8

Updated by Dominic Cleal over 10 years ago

  • Status changed from Assigned to Ready For Testing
  • Translation missing: en.field_release set to 2
Actions #9

Updated by Dominic Cleal over 10 years ago

  • Has duplicate Feature #2214: Specifying host IP address should not be mandatory for unmanaged DNS/DHCP subnets added
Actions #10

Updated by Dominic Cleal over 10 years ago

  • Related to Feature #359: Add support for 'hostname=<hostname>' spoofing for Unattended Installs added
Actions #11

Updated by Greg Sutcliffe over 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF