Project

General

Profile

Actions

Bug #31830

closed

SkeletonLoader component should support any kind of a given node

Added by Amir Fefer over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

SkeletonLoader should support components:

// current implementation
SOME_VALUE || <SkeletonLoader />  // doesn't work for components

// react way
<SkeletonLoader> {<Component />} </SkeletonLoader />  // works for any kind of node
Actions #1

Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8314 added
Actions #2

Updated by The Foreman Bot over 3 years ago

  • Fixed in Releases 2.5.0 added
Actions #3

Updated by Amir Fefer over 3 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF