Project

General

Profile

Actions
Copy link

Bug #31830

closed

SkeletonLoader component should support any kind of a given node

Added by Amir Fefer about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amir Fefer
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8314
Fixed in Releases:
2.5.0
Found in Releases:
Red Hat JIRA:

Description

SkeletonLoader should support components:

// current implementation
SOME_VALUE || <SkeletonLoader />  // doesn't work for components

// react way
<SkeletonLoader> {<Component />} </SkeletonLoader />  // works for any kind of node
Actions
Copy link
 #1

Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8314 added
Actions
Copy link
 #2

Updated by The Foreman Bot about 3 years ago

  • Fixed in Releases 2.5.0 added
Actions
Copy link
 #3

Updated by Amir Fefer about 3 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF