Project

General

Profile

Bug #31830

SkeletonLoader component should support any kind of a given node

Added by Amir Fefer 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Amir Fefer
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8314
Fixed in Releases:
2.5.0
Found in Releases:

Description

SkeletonLoader should support components:

// current implementation
SOME_VALUE || <SkeletonLoader />  // doesn't work for components

// react way
<SkeletonLoader> {<Component />} </SkeletonLoader />  // works for any kind of node

Associated revisions

Revision 089e232c (diff)
Added by Amir Fefer 4 months ago

Fixes #31830 - support children in SkeletonLoader component

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8314 added

#2 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.5.0 added

#3 Updated by Amir Fefer 4 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF